Trailing ? in URL silently fails

[adam12]

Hi Bo,

Hope all is well.

I tried to debug and submit a patch for this but I'm not 100% sure where it's occurring in the source code.

Using an incredibly simple Rack application (listed below) as an example, requests to http://localhost:port/? (with the trailing ?) will fail silently, returning an empty reply. If the debugging is cranked up with -V 5 then the error is logged as DEBUG (http1.c:671): HTTP parser error..

I'm not sure if I'm even in the right area, but I dug into the internals and ended up inside the consume_request_line function. At a certain point, it consumes the path from the request and I wasn't able to see where it went. The on_query call is never reached as it returns on line 186.

iodine/ext/iodine/http1_parser.c

Lines 182 to 189 in 469bdd8

	if (args->on_path(args->parser, (char *)start, tmp - start))
	return -1;
	tmp = start = tmp + 1;
	if (!seek2ch(&tmp, end, ' '))
	return -1;
	if (tmp - start > 0 &&
	args->on_query(args->parser, (char *)start, tmp - start))
	return -1;

Here's the example Rack application:

run ->(env) {
  [200, {}, ["Hello World"]]
}

Cheers.

Adam

[boazsegev]

Hi @adam12 ,

Thank you for opening this issue. 🙏🏻

I can confirm that I can re-create the issue on my machine.

It seems an edge-case issue, never cropped up in any of my use cases - thanks for discovering it 👏🏻👏🏻🙏🏻

I'll mark this as a bug and look for a solution (though I'm not sure an empty query is legal 🤔, I'm certain it should be supported).

I'll keep you posted.

Kindly,
Bo.

[boazsegev]

The issue was with the seek2ch implementation. The memchr based implementation would return the wrong value if the character was found on the starting position 😅

I'll wait for the CI and some tests before I release the fix.

[boazsegev]

Released version 0.7.37 with the fix. 🎉

Thanks again for opening this issue 👍🏻🙏🏻

[adam12]

I was staring at the seek2ch implementation in gdb but I didn't see the issue.

Thanks for the quick fix! 💯 👍