Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer GitHub API creation to PR handlers #246

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Defer GitHub API creation to PR handlers #246

merged 2 commits into from
Apr 28, 2019

Commits on Apr 28, 2019

  1. defer github API creation to PR handlers 

    Whenever a GitHub context is created, tokens are checked and refreshed.
Because GitHub tokens were being used across multiple jobs in a
repository-queue, it could happen that the tokens were expired once a
job later in the queue was started.

This change makes sure the GitHub API is created when the jobs is going
to be processed. That way the tokens are checked at the beginning of
each jobs, instead of at the beginning of the job queue.
    @bobvanderlinden
    bobvanderlinden committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    283d0a3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr-fix-github-tokens

    @bobvanderlinden
    bobvanderlinden authored Apr 28, 2019
    Configuration menu
    Copy the full SHA
    a3f1b87 View commit details
    Browse the repository at this point in the history