Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure framebuffer resizes one dimension at a time #914

Closed
wants to merge 3 commits into from

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented May 29, 2022

Apparently resizing the GL control only horizontally or vertically prevents SwapBuffers from crashing, as described in ocornut/imgui#3321. Building on top of this observation, this PR implements dynamic control resizing by changing only a single dimension per frame until the canvas is fully resized to its target size.

Fixes #913

@glopesdev glopesdev added the bug Something isn't working label May 29, 2022
@glopesdev glopesdev added this to the 2.7.0 milestone May 29, 2022
@glopesdev glopesdev removed the bug Something isn't working label Jun 4, 2022
@glopesdev glopesdev removed this from the 2.7.0 milestone Jun 4, 2022
@glopesdev glopesdev closed this Jun 4, 2022
@glopesdev glopesdev deleted the issue-913 branch August 9, 2022 07:29
@glopesdev
Copy link
Member Author

For reference, the issue was tracked down to malware, specifically see comment below:
ocornut/imgui#3321 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access violation exception when resizing image visualizer canvas
1 participant