Update: Some UI changes for video player #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypress
approved these changes
May 19, 2017
| .bp-media-controls-cc-icon-text { | ||
| background: $white; | ||
| border-radius: 3px; | ||
| background: rgba($black, .3); // Anything less than .3 looks too transparent on IE/Edge |
There was a problem hiding this comment.
not sure if there are advantages/disadvantages over doing:
background: $black; opacity: .3;
There was a problem hiding this comment.
opacity affects the text inside too. We just want to affect the opacity of the background, so we do this instead.
src/lib/viewers/media/Settings.scss
Outdated
| .bp-media-settings-label { | ||
| color: $white; | ||
| } | ||
|
|
There was a problem hiding this comment.
You can combine these:
.bp-media-settings-label, .bp-media-settings-value { //styles that effect both }
1. Tabbing through settings menu no longer shows border over menu items (highlights instead). This is because borders/box-shadow/outline does not play well with table-rows on Safari and IE/Edge. Instead, we'll change background color. 2. CC icon now changes background color to indicate that subtitles are on, instead of the previous white underline. 3. Using overflow-y: auto so that scrollbar doesn't show on hover of settings menu in IE/Edge 4. Using div instead of span for cc-text so I can size it, because using the span resulted in too short of a CC icon on IE/Edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(highlights instead). This is because borders/box-shadow/outline does
not play well with table-rows on Safari and IE/Edge. Instead, we'll
change background color.
on, instead of the previous white underline.
settings menu in IE/Edge
the span resulted in too short of a CC icon on IE/Edge.