Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Some UI changes for video player #128

Merged
merged 2 commits into from
May 19, 2017
Merged

Update: Some UI changes for video player #128

merged 2 commits into from
May 19, 2017

Commits on May 19, 2017

  1. Update: Some UI changes for video player 

    1. Tabbing through settings menu no longer shows border over menu items
(highlights instead). This is because borders/box-shadow/outline does
not play well with table-rows on Safari and IE/Edge. Instead, we'll
change background color.
2. CC icon now changes background color to indicate that subtitles are
on, instead of the previous white underline.
3. Using overflow-y: auto so that scrollbar doesn't show on hover of
settings menu in IE/Edge
4. Using div instead of span for cc-text so I can size it, because using
the span resulted in too short of a CC icon on IE/Edge.
    Bryan Huh committed May 19, 2017
    Configuration menu
    Copy the full SHA
    d8fd1f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into video_ui_touch_up

    @bhh1988
    bhh1988 authored May 19, 2017
    Configuration menu
    Copy the full SHA
    caa6a7c View commit details
    Browse the repository at this point in the history