Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#46 Prevent ProcessInfo.update to overflow DB #67

Closed
wants to merge 1 commit into from

Conversation

Skrattoune
Copy link
Contributor

@Skrattoune Skrattoune commented Jan 27, 2022

Here is the PR fixing issue #46 that has been running in prod since August 2021 without any issue

Temporary fix while we wait for PR #58 to be ready and availlable

Copy link
Contributor Author

@Skrattoune Skrattoune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.
Running in prod since Aug 2021

@jedie
Copy link
Collaborator

jedie commented Jan 28, 2022

Your code looks a little bit "unformatted"... I will take your changes into a new PR...

jedie pushed a commit that referenced this pull request Jan 28, 2022
Don't create a new TaskProgressModel instances for every `ProcessInfo.update()` call and increment a
existing TaskProgressModel instances. So we will not flood the database ;)

Based on #67
@jedie
Copy link
Collaborator

jedie commented Jan 28, 2022

closed in favor of #68 ;)

@jedie jedie closed this Jan 28, 2022
jedie pushed a commit that referenced this pull request Jan 28, 2022
Don't create a new TaskProgressModel instances for every `ProcessInfo.update()` call and increment a
existing TaskProgressModel instances. So we will not flood the database ;)

Based on #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants