Fix #46 By increment existing TaskProgressModel instances #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't create a new TaskProgressModel instances for every `ProcessInfo.update()` call and increment a existing TaskProgressModel instances. So we will not flood the database ;) Based on #67
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 83.46% 83.56% +0.10%
==========================================
Files 35 35
Lines 786 791 +5
==========================================
+ Hits 656 661 +5
Misses 130 130
Continue to review full report at Codecov.
|
|
Thanks a lot! I'll test and update now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create a new TaskProgressModel instances for every
ProcessInfo.update()call and increment aexisting TaskProgressModel instances. So we will not flood the database ;)
Based on #67