Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save password prompt has graphic (C83) #10008

Closed
LaurenWags opened this issue May 29, 2020 · 1 comment · Fixed by brave/brave-core#5715 or brave/brave-core#5743
Closed

save password prompt has graphic (C83) #10008

LaurenWags opened this issue May 29, 2020 · 1 comment · Fixed by brave/brave-core#5715 or brave/brave-core#5743

Comments

@LaurenWags
Copy link
Member

Description

C83 save password prompt has a graphic, where C81 password prompt did not.

Steps to Reproduce

  1. Navigate to a site where you have to save credentials
  2. Login
  3. After login, you should be prompted to save your password

Actual result:

C83:
Screen Shot 2020-05-29 at 2 57 30 PM

Expected result:

C81:
Screen Shot 2020-05-29 at 3 07 06 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.11.37 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the dev channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @mkarolin @brave/legacy_qa

@rebron rebron added OS/Desktop design A design change, especially one which needs input from the design team labels Jun 1, 2020
@mkarolin mkarolin self-assigned this Jun 2, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Jun 2, 2020
bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 3, 2020
@mkarolin mkarolin reopened this Jun 4, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Jun 4, 2020
Replaces 1x1 empty images that we use to overwrite chromium images with
images of 1 x original image width, so that they don't get scaled to the
preferred width of the bubble.

Fixes brave/brave-browser#10008
@mkarolin mkarolin added this to the 1.12.x - Nightly milestone Jun 4, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 8, 2020

Verification passed on

Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified STR from the description, verified in both light and dark themes.
    image

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.15.5 (Build 19F101)

Screen Shot 2020-06-05 at 5 05 29 PM

Screen Shot 2020-06-05 at 5 05 41 PM

Screen Shot 2020-06-05 at 5 07 02 PM

Verification passed on

Brave 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Ubuntu 18.04 LTS
  • Verified STR from the description, verified in both light and dark themes.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants