Do not show graphic in Save Password dialog.

[mkarolin]

Fixes brave/brave-browser#10008

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[mkarolin]

CI: the only failure was unit-tests on Android.

[mkarolin]

A patch instead of an override of PasswordSaveUpdateView::OnThemeChanged because PasswordSaveUpdateView's destructor is private.

[bsclifton]

++

[bsclifton]

Rebased since rewards had a DCHECK error at the time, causing me to crash locally

Ran code - it's working as expected! 😄

Without the patch:

[bridiver]

can't we just override the two images IDR_SAVE_PASSWORD_DARK and IDR_SAVE_PASSWORD to be empty images?

[bridiver]

meaning do a chromium_src override to turn them into some brave resource that is a 1x1 image or something? Also I think it will work if the image is null so maybe try overriding to be IDR_SAVE_PASSWORD_DARK = -1 or something?