Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uphold /me payload from client logs #10082

Closed
NejcZdovc opened this issue Jun 4, 2020 · 1 comment · Fixed by brave/brave-core#6168
Closed

Remove uphold /me payload from client logs #10082

NejcZdovc opened this issue Jun 4, 2020 · 1 comment · Fixed by brave/brave-core#6168

Comments

@NejcZdovc
Copy link
Contributor

No description provided.

@NejcZdovc NejcZdovc self-assigned this Jun 4, 2020
@NejcZdovc NejcZdovc removed their assignment Jun 29, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 22, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 22, 2020
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 22, 2020
@NejcZdovc NejcZdovc added OS/Android Fixes related to Android browser functionality OS/Desktop and removed OS/Android Fixes related to Android browser functionality labels Aug 10, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Aug 17, 2020

Verified passed with

Brave | 1.13.73 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6168

Reproduced issue in 1.12.x using test plan from PR

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me
> Method: UrlMethod::GET
[Aug 17, 2020, 7:47:25.2 AM:VERBOSE6:uphold_user.cc(70)] 
[ RESPONSE - OnGet ]
> Url: https://api-sandbox.uphold.com/v0/me
> Result: Success
> HTTP Code: 200
...

Upgraded to 1.13.x and confirmed no new logs for the /me endpoint where shown, however previous entries from 1.12.x were still in the logs.

Verified test plan from PR on a clean profile also.
Also, confirmed w/ @NejcZdovc the following is ok in the logs for 1.13.x:

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/redacted
> Method: UrlMethod::GET
[Aug 17, 2020, 7:49:05.1 AM:VERBOSE6:uphold.cc(162)] 
[ RESPONSE - OnFetchBalance ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/redacted
> Result: Success
> HTTP Code: 200
...

And

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/redacted/addresses
> Method: UrlMethod::GET
> Content Type: application/json
[Aug 17, 2020, 7:47:25.7 AM:VERBOSE6:uphold.cc(162)] 
[ RESPONSE - OnGetCardAddresses ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/redacted/addresses
> Result: Success
> HTTP Code: 200
...

Verification passed on

Brave | 1.13.76 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me
> Method: UrlMethod::GET
[2016:6340:0818/231733.121:VERBOSE6:uphold_user.cc(70)]
[ RESPONSE - OnGet ]
> Url: https://api-sandbox.uphold.com/v0/me
> Result: Success
> HTTP Code: 200
[ RESPONSE - OnGet ]
> Url: https://api-sandbox.uphold.com/v0/me
> Result: Success
> HTTP Code: 200
  • Verified test plan from PR on a clean profile
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/redacted
> Method: UrlMethod::GET
[Aug 18, 2020, 11:26:47.7 PM:VERBOSE6:uphold.cc(162)] 
[ RESPONSE - OnFetchBalance ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/redacted
> Result: Success
> HTTP Code: 200
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/redacted/addresses
> Method: UrlMethod::GET
> Content Type: application/json
[Aug 18, 2020, 11:25:57.8 PM:VERBOSE6:uphold_card.cc(278)] 
[ RESPONSE - OnGetCardAddresses ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/redacted/addresses
> Result: Success
> HTTP Code: 200

Verification passed on

Brave 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6168

Reproduced the issue on 1.12.x
image
Upgraded to 1.13.x and confirmed no new logs for the /me endpoint where shown, however previous entries from 1.12.x were still in the logs.

  • Verified test plan from PR on a clean profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment