Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes uphold /me from internal logs #6168

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Removes uphold /me from internal logs #6168

merged 1 commit into from
Jul 22, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 22, 2020 •
edited
Loading

Resolves brave/brave-browser#10082

Submitter Checklist:

Test Plan:

  • enable rewards
  • connect kyc account
  • go to rewards internals
  • make sure that in logs you don't see personal data from uphold /me endpoint

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added feature/rewards CI/skip Do not run CI builds (except noplatform) labels Jul 22, 2020
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 22, 2020
@NejcZdovc NejcZdovc requested a review from a team July 22, 2020 11:48
@NejcZdovc NejcZdovc self-assigned this Jul 22, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team July 22, 2020 11:48
NejcZdovc
NejcZdovc commented Jul 22, 2020
View reviewed changes
vendor/bat-native-ledger/src/bat/ledger/internal/uphold/uphold_user.cc
@@ -67,7 +67,7 @@ void UpholdUser::OnGet(
const ledger::UrlResponse& response,
GetUserCallback callback) {
User user;
BLOG(6, ledger::UrlResponseToString(__func__, response));
BLOG(7, ledger::UrlResponseToString(__func__, response));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only log 1-6 in client logs

emerick
emerick approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 6ff6989 into master Jul 22, 2020
@NejcZdovc NejcZdovc deleted the uphold-me branch July 22, 2020 16:04
@LaurenWags LaurenWags mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@zenparsing zenparsing zenparsing approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.

Remove uphold /me payload from client logs
3 participants
@NejcZdovc @emerick @zenparsing