Search Engines added by Extensions unavailable in Private Window

[ppittle]

Description

Search Engines added by Extensions can't be referenced by Keyword + Tab in Private Window

Given the user has installed an Extension which adds a Search Engine
And the user has modified the Extension so that "Allow in private" is true.

Given the user is in a Private Window
And the Address Bar has Focus
When the user types the Extension's Search Keyword and presses Tab

Then further input is directed to the Extension's Search Engine

Scenario fails for Private Window:

Works with a 'normal' Window:

Steps to Reproduce

1. Install an Extension that Provides a Search Engine. I used LastPass

brave://settings/searchEngines

2. Ensure the Extension is available in Private

brave://extensions/?id=hdokiejnpimakedhajhdlcegeplioahd

3. Open a new Private Window
4. Focus the Address Bar
5. Type the Extension's Search Engine Keyword and press Tab. (In the case of LastPass, it's lp)

Actual result:

Tab Cycles through the History list that appears in the Address bar. Control is not routed to the Extension's Search Engine.

Expected result:

Private Window should behave as a 'normal' Window does. Input should be routed to the Extension's Search Engine

Reproduces how often:

Always reproduces

Brave version (brave://version info)

Brave | 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1909 (Build 18363.900)

Version/Channel Information:

• Can you reproduce this issue with the current release? YES
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NO
• Does the issue resolve itself when disabling Brave Rewards? NO
• Is the issue reproducible on the latest version of Chrome? NO

Miscellaneous Information:

[atahabaki]

Hi!..

I'm facing that too...

I've developed a Chrome extension which uses Chromium's Omnibox API for quickly search anything, anywhere. Then uploaded it to Chrome web store which I called it "smartbox: Smart Searching".

If you're interested in, you can take a look at here.

It works pretty well with Google Chrome (works on incognito mode too). On Brave, it is not working.

Please fix this issue. Maybe this is not an issue but. Make an exception for this to work on both private and Tor sessions too.

Have a great day.

[bsclifton]

Related (or possible duplicate of) #10549

[ppittle]

Agree this and #10549 appear to be the same root issue. But I will point out, mine has more pictures :D

[stephendonner]

Verified PASSED using the testplan from brave/brave-core#8626 with build

Brave	1.26.22 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	macOS Version 11.3.1 (Build 20E241)

Steps:

1. clean profile, launched Brave
2. installed Ecosia extension - https://chrome.google.com/webstore/detail/ecosia-the-search-engine/eedlgdlajadkbbjoobobefphmfkcchfk/related
3. confirmed Normal window's default search provider is ecosia
4. opened private window and confirmed ecosia is default search provider
5. toggled DDG button to On and confirmed it doesn't change the search provider - still using Ecosia
6. toggled DDG button to Off and confirmed it doesn't change the search provider - still using Ecosia
7. in brave://extensions, on the Ecosia extension details page, I toggled Allow in private on and off
8. confirmed changing Allow in private option doesn't affect private window's search provider - still using Ecosia
9. disabled Ecosia extension and check normal and private windows use default search provider - uses Google
10. toggled DDG button to On in Private and confirmed search provider is changed to DuckDuckGo

steps 1-2	step 3	step 4	step 5	step 6	step 7	step 8	step 9	step 10

---

Verification passed on

<!--StartFragment-->
Brave | 1.26.47 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

• Verified the test plan from fixed crash with search extension brave-core#8626

example	example	example	example	example	example	example	example	example	example	example	example	example

---

Verification passed on

Brave	1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

Extension was unable to change default search engine in Normal Window nor Private Window. Logged #16227

[LaurenWags]

Testing brave/brave-core#8626 will cover the following issues:

• crash when searching via private window while having SE extension set as Allow in private #15224
• Search Engines added by Extensions unavailable in Private Window #10601 (this issue)
• Crash in settings_overridden_params::GetSearchOverriddenParams #14218