Crash in settings_overridden_params::GetSearchOverriddenParams

[iefremov]

[ 00 ] settings_overridden_params::GetSearchOverriddenParams(Profile*)
[ 01 ] extensions::MaybeShowExtensionControlledSearchNotification(content::WebContents*, AutocompleteMatchType::Type)
[ 02 ] OmniboxEditModel::OpenMatch(AutocompleteMatch, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long, base::TimeTicks)
[ 03 ] OmniboxView::OpenMatch(AutocompleteMatch const&, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long, base::TimeTicks)
[ 04 ] OmniboxEditModel::AcceptInput(WindowOpenDisposition, base::TimeTicks)
[ 05 ] OmniboxViewViews::HandleKeyEvent(views::Textfield*, ui::KeyEvent const&)
[ 06 ] views::Textfield::OnKeyPressed(ui::KeyEvent const&)
[ 07 ] non-virtual thunk to views::View::OnKeyEvent(ui::KeyEvent*)
[ 08 ] ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*)
[ 09 ] ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*)
[ 10 ] ui::EventProcessor::OnEventFromSource(ui::Event*)
[ 11 ] ui::EventSource::SendEventToSinkFromRewriter(ui::Event const*, ui::EventRewriter const*)
[ 12 ] views::Widget::OnKeyEvent(ui::KeyEvent*)
[ 13 ] non-virtual thunk to views::NativeWidgetMac::DispatchKeyEventPostIME(ui::KeyEvent*)

https://brave.sp.backtrace.io/p/brave/triage?filters=((callstack.functions%2Ccontains%2CGetSearchOverriddenParams)%2Cptype%3Dbrowser)&aggregations=((channel%2Cdistribution%2C3)%2C(ptype%2Chead)%2C(uname.sysname%2Cdistribution%2C3))

[iefremov]

maybe related to #15140

[stephendonner]

Verified PASSED using the testplan from brave/brave-core#8626 with build

Brave	1.26.24 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	macOS Version 11.3.1 (Build 20E241)

I confirmed both the functionality is correct, as well as -- more importantly for this issue -- that I didn't have any crashes 👍

Steps:

1. new profile, launched Brave
2. installed Ecosia extension from https://chrome.google.com/webstore/detail/ecosia-the-search-engine/eedlgdlajadkbbjoobobefphmfkcchfk/related
3. confirmed Normal window's default search provider was Ecosia
4. opened a New Private Window and confirmed Ecosia is the default search provider
5. toggled DuckDuckGo button to On and confirmed search provider is still Ecosia
6. toggled DuckDuckGo button to Off and confirmed search provider is still Ecosia
7. went to brave://extensions, clicked on Details for Ecosia extension, and toggled Allow in private repeatedly
8. confirmed changing Allow in private option doesn't affect private window's search provider - still used Ecosia
9. disabled Ecosia extension via its Details page from brave://extensions and confirmed normal and private windows both use default search provider - Google, in my case
10. toggled DuckDuckGo button to On in New Private Window tab and confirmed search provider is changed to DuckDuckGo

example	example	example	example	example	example	example	example

---

Verification passed on

<!--StartFragment-->
Brave | 1.26.47 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

• Verified the test plan from fixed crash with search extension brave-core#8626

example	example	example	example	example	example	example	example	example	example	example	example	example

---

Verification passed on

Brave	1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

Extension was unable to change default search engine in Normal Window nor Private Window. Logged #16227

[LaurenWags]

Testing brave/brave-core#8626 will cover the following issues:

• crash when searching via private window while having SE extension set as Allow in private #15224
• Search Engines added by Extensions unavailable in Private Window #10601
• Crash in settings_overridden_params::GetSearchOverriddenParams #14218 (this issue)