Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Promotion server url handling #11203

Closed
NejcZdovc opened this issue Aug 12, 2020 · 2 comments · Fixed by brave/brave-core#6422
Closed

[Desktop] Promotion server url handling #11203

NejcZdovc opened this issue Aug 12, 2020 · 2 comments · Fixed by brave/brave-core#6422
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.14.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

Ref: #10987
@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 12, 2020
@NejcZdovc NejcZdovc self-assigned this Aug 12, 2020
@NejcZdovc NejcZdovc mentioned this issue Aug 12, 2020
Closed
6 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 13, 2020
@NejcZdovc
Moves promotions to new endpoint structure
4486914 
Resolves brave/brave-browser#11203
@NejcZdovc NejcZdovc mentioned this issue Aug 14, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added OS/Android Fixes related to Android browser functionality QA/Yes and removed QA/No labels Aug 17, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 17, 2020
@NejcZdovc
Moves promotions to new endpoint structure
aaab482 
Resolves brave/brave-browser#11203
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 17, 2020
@NejcZdovc
Moves promotions to new endpoint structure
6baff0d 
Resolves brave/brave-browser#11203
@LaurenWags
Copy link
Member

LaurenWags commented Aug 31, 2020 •
edited by btlechowski
Loading

Verification passed using

Brave	1.14.69 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision	94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6422 using staging env.

1. Confirmed able to claim UGP grant 1
2. Confirmed able to claim Ad grant 2
3. After claiming ad grant, confirmed Ad grant moved to Uphold 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/.........../claim
> Method: UrlMethod::POST
> Content: ...

[5201:775:0831/151729.581645:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/.........../claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body:
3a 3b 3c
4. Confirmed able to 1 time tip with VG 4a 4b
5. Confirmed able to do a recurring tip with VG (AC off) 5a 5b
6. Confirmed able to do a recurring tip with VG (AC on but empty) 6a 6b
7. Confirmed able to do a recurring tip + AC with VG 7a 7b
8. Confirmed able to do AC only with VG 8a 8b
9. Confirmed able to do one time tip with Uphold 9a 9b 9c
10. Confirmed able to do a recurring tip with Uphold (AC off) 10a 10b 10c
11. Confirmed able to do a recurring tip with Uphold (AC on but empty) 11a 11b 11c
12. Confirmed able to do a recurring tip + AC with Uphold 12a 12b 12c
13. Confirmed able to do AC only with Uphold 13a 13b 13c
14. Confirmed able to restore a wallet with a waiting Ad grant 14
15. Confirmed able to restore a wallet with anon user BAT 15a 15b

Verification is in-progress

Brave | 1.14.76 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)
1. Confirmed able to claim UGP grant

image

2. Confirmed able to claim Ad grant

image

3. After claiming ad grant, confirmed Ad grant moved to Uphold 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/..../claim
> Method: UrlMethod::POST
> Content: 

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/..../claim
> Result: Success
> HTTP Code: 200

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: 

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

image
image

4. Confirmed able to 1 time tip with VG

image
image

5. Confirmed able to do a recurring tip with VG (AC off)

image
image
image

6. Confirmed able to do a recurring tip with VG (AC on but empty)

image
image
image

7. Confirmed able to do a recurring tip + AC with VG

image
image
image

8. Confirmed able to do AC only with VG

image
image
image

9. Confirmed able to do one time tip with Uphold ![image](https://user-images.githubusercontent.com/38657976/92411500-bfcb8b00-f165-11ea-93ae-044c76b2ba38.png) ![image](https://user-images.githubusercontent.com/38657976/92411504-c954f300-f165-11ea-801a-ba6b257eb46f.png) ![image](https://user-images.githubusercontent.com/38657976/92411556-f7d2ce00-f165-11ea-9232-4a9b8ab025c8.png)
10. Confirmed able to do a recurring tip with Uphold (AC off)

image
image
image
image

11. Confirmed able to do a recurring tip with Uphold (AC on but empty)

image
image
image
image

12. Confirmed able to do a recurring tip + AC with Uphold

image
image
image
image

13. Confirmed able to do AC only with Uphold

image
image
image
image

14. Confirmed able to restore a wallet with a waiting Ad grant

image

15. Confirmed able to restore a wallet with anon user BAT

image
image

Verification passed on

Brave 1.14.75 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6422 using staging env.

1. Confirmed able to claim UGP grant

image

2. Confirmed able to claim Ad grant

image

3. After claiming ad grant, confirmed Ad grant moved to Uphold 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[]/claim
> Method: UrlMethod::POST

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[]/claim
> Result: Success
> HTTP Code: 200

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
4. Confirmed able to 1 time tip with VG

image

7. Confirmed able to do a recurring tip + AC with VG

image

9. Confirmed able to do one time tip with Uphold

image

12. Confirmed able to do a recurring tip + AC with Uphold

image

@srirambv srirambv mentioned this issue Sep 15, 2020
Closed
5 tasks
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.14.83 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging a pull request may close this issue.

Moves promotions to new endpoint structure brave/brave-core
5 participants
@NejcZdovc @srirambv @LaurenWags @btlechowski @GeetaSarvadnya