Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Notification not shown when 10mins of browsing time is saved #11527

Closed
srirambv opened this issue Aug 31, 2020 · 3 comments
Closed
Assignees
Labels
bug feature/notifications OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 31, 2020

Description

[Follow up to brave/brave-core/pull/6268] Notification not shown when 10mins of browsing time is saved

Steps to reproduce

  1. Follow steps from Retention notifications dp brave-core#6268

Actual result

No notification shown

Expected result

Should show notification

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.15.22

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv
Copy link
Contributor Author

srirambv commented Sep 2, 2020

Marking p1 as this is part of the notification feature going in the release. @bsclifton @anthonypkeane please change if you think otherwise

@kjozwiak kjozwiak added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking labels Sep 2, 2020
@kjozwiak kjozwiak removed this from the Android 1.13.x - Release milestone Sep 2, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 2, 2020

Needs more investigation from @srirambv 👍 Will most likely miss 1.13.x and get resolved in 1.14.x unless @deeppandya can reproduce.

@srirambv
Copy link
Contributor Author

srirambv commented Sep 3, 2020

This is working as expected. Notification is shown and clicking on it opens NTP as per spec.
image

Closing as expected and moving it back to 1.13.x and marking it as verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/notifications OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants