Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding v2 with retention notification (uplift to 1.13.x) #6494

Merged
merged 27 commits into from
Sep 1, 2020

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 25, 2020

Uplifts of
#6268
#6378
#6395
#6398
#6447
#6517
#6518
#6537
#6539

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added this to the 1.13.x - Release milestone Aug 25, 2020
@deeppandya deeppandya requested a review from a team August 25, 2020 16:57
@deeppandya deeppandya self-assigned this Aug 25, 2020
@deeppandya deeppandya changed the title Retention notifications 1.13.x (uplift to 1.13.x) [WIP] Retention notifications 1.13.x (uplift to 1.13.x) Aug 26, 2020
@deeppandya deeppandya force-pushed the retention_notifications_1.13.x branch from 6893d72 to c250f6b Compare August 26, 2020 05:47
@deeppandya deeppandya force-pushed the retention_notifications_1.13.x branch from e892859 to d0df1b1 Compare August 31, 2020 02:30
@deeppandya deeppandya changed the title [WIP] Retention notifications 1.13.x (uplift to 1.13.x) Retention notifications 1.13.x (uplift to 1.13.x) Aug 31, 2020
@deeppandya deeppandya changed the title Retention notifications 1.13.x (uplift to 1.13.x) Onboarding v2 with retention notification (uplift to 1.13.x) Aug 31, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.15.22 x64 nightly build

@srirambv
Copy link
Contributor

Follow up issue brave/brave-browser#11527

@kjozwiak
Copy link
Member

test-install failed on Win x64 as per https://ci.brave.com/job/pr-brave-browser-retention_notifications_1.13.x-windows/9/execution/node/242/log/. We usually like to get test-install passing but it's not the most reliable when it comes to stability. Other platforms passed without any issues and we've seen this failure happen on other PRs as well. Hence, not blocking uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nighty as per #6494 (comment).

@kjozwiak kjozwiak merged commit 6f203ee into 1.13.x Sep 1, 2020
@kjozwiak kjozwiak deleted the retention_notifications_1.13.x branch September 1, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants