Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention notifications dp #6268

Merged
merged 6 commits into from
Jul 30, 2020
Merged

Retention notifications dp #6268

merged 6 commits into from
Jul 30, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves : brave/brave-browser#10191

Submitter Checklist:

Test Plan:

Follow steps on https://docs.google.com/spreadsheets/d/1D_RnP1cQVNf3szSCKcYCqcIN3IjrlXnQwoLTxjEt3V0/edit#gid=0

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 30, 2020
@deeppandya deeppandya added this to the 1.13.x - Beta milestone Jul 30, 2020
@deeppandya deeppandya self-assigned this Jul 30, 2020
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit ede04c7 into master Jul 30, 2020
@deeppandya deeppandya deleted the retention_notifications_dp branch July 30, 2020 20:20
@deeppandya
Copy link
Contributor Author

Uplift this issue to 1.13. currently blocked on #6263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Onboarding Notification
3 participants