Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps *brave_process* target in //brave/browser/ #12084

Closed
Gyuyoung opened this issue Oct 12, 2020 · 1 comment
Closed

Fix deps *brave_process* target in //brave/browser/ #12084

Gyuyoung opened this issue Oct 12, 2020 · 1 comment

Comments

@Gyuyoung
Copy link

$ gn check . //brave/browser/*
ERROR at //brave/browser/brave_rewards/extension_rewards_service_observer.cc:15:11: Include not allowed.
#include "chrome/browser/profiles/profile.h"
          ^--------------------------------
It is not in any dependency of
  //brave/browser:browser_process
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/brave_rewards/extension_rewards_notification_service_observer.cc:13:11: Include not allowed.
#include "chrome/browser/profiles/profile.h"
          ^--------------------------------
It is not in any dependency of
  //brave/browser:browser_process
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/brave_drm_tab_helper.cc:13:11: Include not allowed.
#include "chrome/browser/browser_process_impl.h"
          ^------------------------------------
It is not in any dependency of
  //brave/browser:browser_process
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/brave_drm_tab_helper.cc:14:11: Include not allowed.
#include "chrome/browser/profiles/profile.h"
          ^--------------------------------
It is not in any dependency of
  //brave/browser:browser_process
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/brave_content_browser_client.h:14:11: Include not allowed.
#include "chrome/browser/chrome_content_browser_client.h"
          ^---------------------------------------------
It is not in any dependency of
  //brave/browser:browser_process
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.

@mariospr
Copy link
Contributor

Closing this one as it's a duplicate of #12623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment