Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps *brave_process* target in //brave/browser/ #6830

Closed
wants to merge 1 commit into from

Conversation

Gyuyoung
Copy link
Contributor

Resolves brave/brave-browser#12084.

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@Gyuyoung Gyuyoung force-pushed the gyuyoung-brwoser-process-target branch from c385153 to bf80c8f Compare October 12, 2020 02:14
@@ -4,9 +4,49 @@
# You can obtain one at http://mozilla.org/MPL/2.0/.

import("//brave/browser/importer/sources.gni")
import("//brave/components/binance/browser/buildflags/buildflags.gni")
import("//third_party/widevine/cdm/widevine.gni")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to include widevine.gni to use enable_widevine guard in line #45. But, it causes below import loop error.

FAILED: build.ninja 
../../buildtools/linux64/gn --root=../.. -q gen .
ERROR //build/config/chrome_build.gni is part of an import loop.
See //brave/browser/sources.gni:8:1: whence it was imported.
import("//third_party/widevine/cdm/widevine.gni")
^-----------------------------------------------
See //brave/build/config/brave_build.gni:6:1: whence it was imported.
import("//brave/browser/sources.gni")
^-----------------------------------
See //build/config/chrome_build.gni:4:1: whence it was imported.
import("//brave/build/config/brave_build.gni")
^--------------------------------------------
See //build/config/compiler/compiler.gni:5:1: whence it was imported.
import("//build/config/chrome_build.gni")
^---------------------------------------
See //BUILD.gn:11:1: whence it was imported.
import("//build/config/compiler/compiler.gni")
^--------------------------------------------
ninja: error: rebuilding 'build.ninja': subcommand failed

@Gyuyoung Gyuyoung closed this Oct 12, 2020
@Gyuyoung Gyuyoung deleted the gyuyoung-brwoser-process-target branch October 12, 2020 02:18
@Gyuyoung Gyuyoung restored the gyuyoung-brwoser-process-target branch October 12, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deps *brave_process* target in //brave/browser/
1 participant