-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default search should be versioned #12231
Comments
…ofiles missing this version. Fixes brave/brave-browser#12231
…ofiles missing this version. Fixes brave/brave-browser#12231
…ofiles missing this version. Fixes brave/brave-browser#12231
Desktop can be tested via test plan in brave/brave-core#7090, however pending Android specific test plan from @bsclifton 👍 |
Verification passed on
Verified test plan from brave/brave-core#7090 (some verification were done in #12327) Verified Russia on upgraded profile from 1.17.x Verification passed on LG Nexus 5 with Android 5.1 running 1.18.70 Bravearm.apk Verified test plan from brave/brave-core#7090 (comment) for Armenian and Russian. For a new profile, confirmed that For existing profile with default SE never modified, confirmed that updating from For existing profile with default SE changed, confirmed that updating from
|
Onboarding |
Settings |
---|---|
Russian
new profile
Onboarding |
Settings |
---|---|
Additional testing notes can be found under #12979 (comment)
Test plan
See brave/brave-core#7090
Description
Right now, there's not a way to tell what the default search engine was when the user's profile was created.
If the default is changed, anyone who has not set the search engine explicitly will get the NEW default.
Steps to Reproduce
Actual result:
It doesn't matter if person had been using the default. The new default will be used instead (ex: Bing). The only way the value is retained is when they have changed the default explicitly
Expected result:
If user profile has existed for a while, the original provider for default search engine should be preserved (ex: Google in this case)
Reproduces how often:
100%
The text was updated successfully, but these errors were encountered: