Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Yandex in some regions #12327

Closed
bsclifton opened this issue Oct 26, 2020 · 2 comments · Fixed by brave/brave-core#7090
Closed

Introduce Yandex in some regions #12327

bsclifton opened this issue Oct 26, 2020 · 2 comments · Fixed by brave/brave-core#7090

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 26, 2020

Test plan

See brave/brave-core#7090

Description

Yandex is not currently shown in any default lists (it can only be added via Open Search). Searches made using that Open Search entry are are not being attributed to Brave.

The goal for this issue would be to:

  • Add Yandex for applicable regions
  • Set as default for applicable regions
  • Ensure the URL used for search attributes Brave for search results

Applicable regions

  1. Republic of Armenia (AM)
  2. Republic of Azerbaijan (AZ)
  3. Republic of Belarus (BY)
  4. Kyrgyz Republic (KG)
  5. Republic of Kazakhstan (KZ)
  6. Republic of Moldova (MD)
  7. Russian Federation (RU)
  8. Republic of Tajikistan (TJ)
  9. Turkmenistan (TM)
  10. Republic of Uzbekistan (UZ)
@bsclifton bsclifton added feature/search OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 26, 2020
@bsclifton bsclifton self-assigned this Oct 26, 2020
@bsclifton bsclifton added this to the 1.19.x - Nightly milestone Nov 21, 2020
@LaurenWags
Copy link
Member

Verified passed on LG Nexus 5 with Android 5.1 running 1.18.69 Bravearm.apk

Verified test cases outlined under brave/brave-core#7258 (comment) for the following languages:

  1. Armenian (Republic of Armenia)
  2. Russian (spoken in Republic of Belarus, Kyrgyz Republic, Republic of Kazakhstan, Russian Federation, Republic of Tajikistan, Turkmenistan, Republic of Uzbekistan)
Armenian Russian
Armenian Russian

Unable to confirm the above for the following as my device does not have these languages:

  1. Azerbaijani (Republic of Azerbaijan)
  2. Belarusian (Republic of Belarus)
  3. Kyrgyz (Kyrgyz Republic)
  4. Kazakh (Republic of Kazakhstan)
  5. Moldovan (Republic of Moldova)
  6. Tajiki (Republic of Tajikistan)
  7. Turkmen (Turkmenistan)
  8. Uzbek (Republic of Uzbekistan)

@btlechowski
Copy link

btlechowski commented Dec 9, 2020

Verification passed on

Brave 1.18.69 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#7090

Verified Russia, Armenia, Azerbaijan, Belarus, Kyrgyz, Kazakh, Moldovan, Tajiki, Turkmen, Uzbek on clean profile
Verified Onboarding:
image
Verified default search engine in Normal Window
Verified searching via the URL bar uses the clid=2423859 attribution
image
Verified default search engine in Private Window
Verified searching via the URL bar uses the clid=2423859 attribution
image
Verified Yandex is default search trough context menu
image
Verified search trough context menu uses the clid=2423859 attribution
Verified Duckduckgo is used as default engine in Private Window with Tor
image

Verified Russia on upgraded profile from 1.17.x
On 1.17.x
image
On 1.18.x
image

Verified US - sanity check
Verified Onboarding:
Goggle is default
image
Verified default search engine in Normal Window
image
Verified default search engine in Private Window
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants