Fix iOS compiling

[Brandon-T]

Description

iOS is not compiling on the CI but it compiles locally. The fix is to change the signature of a callback function to be explicit.

Steps to reproduce

1. Compile iOS Sync on the CI.

Actual result

Fails to compile.

Expected result

Should compile.

Issue reproduces how often

Version/Channel Information:

Device details

• Install type (ARM, x86): Any
• Device type (Phone, Tablet, Phablet):Any
• iOS version: Any

Additional information

None.

[yrliou]

error message:

[2020-12-02T04:39:29.917Z] FAILED: obj/brave/ios/browser/api/bookmarks/bookmarks/brave_bookmarks_api.o 
[2020-12-02T04:39:29.918Z] /Users/jenkins/jenkins/workspace/pr-brave-browser-ipfs_add_redirect_check-ios/src/brave/script/redirect-cc.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/brave/ios/browser/api/bookmarks/bookmarks/brave_bookmarks_api.o.d -DBRAVE_CHROMIUM_BUILD -DOFFICIAL_BUILD -DCR_XCODE_VERSION=1160 -DCR_CLANG_REVISION=\"llvmorg-12-init-5035-gd0abc757-3\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_NODISCARD -DCR_LIBCXX_REVISION=375504 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNS_BLOCK_ASSERTIONS=1 -DWEBP_EXTERN=extern -DOPENSSL_NO_ASM -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DWEBRTC_ENABLE_AVX2 -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DWEBRTC_IOS -DABSL_ALLOCATOR_NOTHROW=1 -DWEBRTC_USE_BUILTIN_ISAC_FIX=0 -DWEBRTC_USE_BUILTIN_ISAC_FLOAT=1 -DHAVE_SCTP -DNO_MAIN_THREAD_WRAPPING -I../../brave/chromium_src -I../.. -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../third_party/libwebp/src -I../../third_party/libyuv/include -I../../third_party/jsoncpp/source/include -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc  -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -enable-dse-memoryssa=false -fcomplete-member-pointers -arch x86_64 -no-canonical-prefixes -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wextra-semi -Wunguarded-availability -Wundeclared-selector -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-psabi -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-final-dtor-non-final-class -Wno-builtin-assume-aligned-alignment -Wno-deprecated-copy -Wno-non-c-typedef-for-linkage -Wno-max-tokens -Oz -fno-omit-frame-pointer -g2 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.6.sdk -mios-simulator-version-min=12.0 -ftrivial-auto-var-init=pattern -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-shorten-64-to-32 -std=c++14 -fno-trigraphs -Wno-trigraphs -fobjc-call-cxx-cdtors -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -fobjc-arc -c ../../brave/ios/browser/api/bookmarks/brave_bookmarks_api.mm -o obj/brave/ios/browser/api/bookmarks/bookmarks/brave_bookmarks_api.o
[2020-12-02T04:39:29.918Z] ../../brave/ios/browser/api/bookmarks/brave_bookmarks_api.mm:321:43: error: cannot initialize a parameter of type 'BOOL (^ _Nonnull)(BookmarkFolder * _Nonnull __strong)' with an rvalue of type 'bool (^)()'
[2020-12-02T04:39:29.918Z]   return [self nestedChildFoldersFiltered:^{ return true; }];
[2020-12-02T04:39:29.918Z]                                           ^~~~~~~~~~~~~~~~~
[2020-12-02T04:39:29.918Z] ../../brave/ios/browser/api/bookmarks/brave_bookmarks_api.h:76:83: note: passing argument to parameter 'included' here
[2020-12-02T04:39:29.918Z] - (NSArray<BookmarkFolder*>*)nestedChildFoldersFiltered:(BOOL(^)(BookmarkFolder*))included
[2020-12-02T04:39:29.918Z]                                                                                   ^
[2020-12-02T04:39:29.918Z] 1 error generated.