Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback to iOS sync function #7311

Closed
wants to merge 2 commits into from
Closed

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Dec 2, 2020

Resolves: Compiling Sync code.
Fixes: brave/brave-browser#12997

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ios CI is green, might need to create a new tracking issue to be associated with this PR tho.

@yrliou yrliou added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 2, 2020
@yrliou yrliou removed CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 2, 2020
@bsclifton
Copy link
Member

Closing in favor of #7320 - I think CI is having a problem w/ the / in the branch name. I can't see any other problems in logs. Instead of pinning to branch (when doing jq command line magic) it uses master

@bsclifton bsclifton closed this Dec 2, 2020
@bsclifton bsclifton deleted the bugfix/iOS-Sync-Compile branch December 2, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix iOS compiling
3 participants