Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome to Brave isn't not translated in non-English language #13118

Closed
GeetaSarvadnya opened this issue Dec 9, 2020 · 2 comments · Fixed by brave/brave-core#7418
Closed

Comments

@GeetaSarvadnya
Copy link

Description

Welcome to Brave isn't not translated in non-English language

Steps to Reproduce

  1. Set OS locale to Kannada
  2. Launch brave with clean profile 1.18.x
  3. Welcome to Barve is not translated to Kannada

Actual result:

image

Expected result:

Welcome to Brave should be translated to Kannada

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.18.69 Chromium: 87.0.4280.88 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) (64-ಬಿಟ್)
ಪರಿಷ್ಕರಣೆ 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Windows 10 OS Version 1809 (Build 17763.1637)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @mkarolin @brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya changed the title Welcome to Brave isn't not translated in non-English langauge Welcome to Brave isn't not translated in non-English language Dec 9, 2020
@mkarolin
Copy link
Contributor

@GeetaSarvadnya, is this a regression?

@mkarolin mkarolin self-assigned this Dec 12, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Dec 12, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 14, 2020
@mkarolin mkarolin added this to the 1.20.x - Nightly milestone Dec 14, 2020
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 20, 2021

Verification passed on


Brave | 1.20.84 Chromium: 88.0.4324.96 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) dev (64-ಬಿಟ್)
-- | --
ಪರಿಷ್ಕರಣೆ | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)


  • Verified the STR from the description
    image

Verified passed with

Brave	1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified STR from description for a few different languages (Kannada is not available on my machine):

German French Hindi
German French Hindi

Verification passed on

Brave 1.20.86 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Verified STR from description

Romanian
image

Polish
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants