Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes l10n of "Welcome to Brave" page title. #7418

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#13118

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Dec 12, 2020
@mkarolin mkarolin force-pushed the maxk-fix-welcome-page-title-l10n branch from a225769 to ceb301f Compare December 12, 2020 05:17
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mkarolin mkarolin force-pushed the maxk-fix-welcome-page-title-l10n branch 2 times, most recently from 6dd6331 to 1e39286 Compare December 12, 2020 16:30
@mkarolin
Copy link
Collaborator Author

Rebased

@mkarolin mkarolin force-pushed the maxk-fix-welcome-page-title-l10n branch from 1e39286 to 2933f14 Compare December 12, 2020 18:56
@mkarolin
Copy link
Collaborator Author

Added guards for Android.

@mkarolin
Copy link
Collaborator Author

CI failure on iOS: known unrelated test ([AdsWrapperTest testPreferencePersistance])

@mkarolin mkarolin merged commit 60b949c into master Dec 14, 2020
@mkarolin mkarolin deleted the maxk-fix-welcome-page-title-l10n branch December 14, 2020 18:05
@mkarolin mkarolin added this to the 1.20.x - Nightly milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome to Brave isn't not translated in non-English language
2 participants