Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android referrals not initializing correctly #15009

Closed
kkuehlz opened this issue Mar 30, 2021 · 1 comment · Fixed by brave/brave-core#8382
Closed

Android referrals not initializing correctly #15009

kkuehlz opened this issue Mar 30, 2021 · 1 comment · Fixed by brave/brave-core#8382
Assignees
@kkuehlz
Labels
feature/referral-promo OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No QA/Test-All-Device-Types QA/Test-All-Platforms regression release/blocking release-notes/exclude
Milestone
1.22.x - Release #5

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Mar 30, 2021

Description

Referrals is not initializing on Android release. Some devices are returning a network changed error when talking to the laptop updates server. Also in brave/brave-core#8274 the timestamp persisting logic is not correct on Android messing with confirmations.

Steps to reproduce

  1. Get a clean build of brave from a referral link (from a whitelisted referrer)
  2. Open the browser
  3. navigate to brave://local-state

Actual result

There is no download_id

Expected result

There should be a download_id.

Issue reproduces how often

Often on Android devices, always reproduces on the Android Simulator.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
    Y
  • Can you reproduce this issue with the current Play Store Beta version?
    Y
  • Can you reproduce this issue with the current Play Store Nightly version?
    Y

Test Plan

Go through the regular referral flow on Android, including confirmation.
@kkuehlz kkuehlz added the OS/Android Fixes related to Android browser functionality label Mar 30, 2021
@kkuehlz kkuehlz self-assigned this Mar 30, 2021
@kkuehlz kkuehlz added priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/referral-promo regression labels Mar 30, 2021
@kkuehlz kkuehlz added the QA/Yes label Mar 30, 2021
yachtcaptain23 added a commit to brave/brave-core that referenced this issue Mar 30, 2021
@yachtcaptain23
Retry referral ping if the referral ping has an error on retry.
97558dd 
Closes brave/brave-browser#15009
@yachtcaptain23 yachtcaptain23 mentioned this issue Mar 30, 2021
Merged
24 tasks
kkuehlz pushed a commit to brave/brave-core that referenced this issue Mar 30, 2021
@yachtcaptain23
Retry referral ping if the referral ping has an error on retry.
5f1630b 
Closes brave/brave-browser#15009
@kkuehlz kkuehlz changed the title Android referrals not initializing correctly Android referrals not initializing correctly (uplift to 1.22.x) Mar 30, 2021
@kkuehlz kkuehlz changed the title Android referrals not initializing correctly (uplift to 1.22.x) Android referrals not initializing correctly Mar 30, 2021
kkuehlz pushed a commit to brave/brave-core that referenced this issue Mar 30, 2021
@yachtcaptain23
Retry referral ping if the referral ping has an error on retry.
32511c9 
Closes brave/brave-browser#15009
@kjozwiak kjozwiak added this to the 1.22.x - Release #5 milestone Mar 30, 2021
@kkuehlz kkuehlz mentioned this issue Mar 31, 2021
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2021

Labeling as QA/No as verifications will be completed via #15034 which is basically the same issue as per @keur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkuehlz kkuehlz

Labels
feature/referral-promo OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No QA/Test-All-Device-Types QA/Test-All-Platforms regression release/blocking release-notes/exclude
Projects
None yet
Milestone
1.22.x - Release #5
Development

Successfully merging a pull request may close this issue.

Retry referral ping if the first referral ping has an error. brave/brave-core
2 participants
@kjozwiak @kkuehlz