Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry referral ping if the first referral ping has an error. #8382

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

yachtcaptain23
Copy link
Contributor

Resolves brave/brave-browser#15009

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test plan in issue

@kkuehlz kkuehlz requested a review from bridiver March 30, 2021 00:37
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review this PR but approved to prevent blocking this PR as @keur already approved.
and I should remove my name from ownerlist for this file :)

@kkuehlz
Copy link
Contributor

kkuehlz commented Mar 30, 2021

good to merge. CI is pylint and npm stuff. unrelated to this PR.

@kjozwiak
Copy link
Member

QA was completed via #8396 (comment) on master before uplifting these changes into 1.23.x & 1.22.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android referrals not initializing correctly
5 participants