Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shields show same values for Ads/Trackers Blocked and HTTPS Upgrades #1525

Closed
LaurenWags opened this issue Oct 11, 2018 · 1 comment · Fixed by brave/brave-core#617
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 11, 2018

Test plan

See brave/brave-core#617

Description

Shields are showing the same count/values for Ads/Trackers Blocked and HTTPS Upgrades.

Steps to Reproduce

  1. Clean profile.
  2. Visit nytimes, cnn, or orlandosentinel.com
  3. Look at shields

Actual result:

Counts are the same, when you click on the number to view an item lists are the same:
screen shot 2018-10-11 at 10 07 24 am

screen shot 2018-10-11 at 10 11 37 am

Expected result:

These values should be accurate.

Reproduces how often:

easy

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Reproduces on Beta 0.55.12, does not reproduce on Dev 0.56.2 or Beta 0.55.11
  • Does it reproduce on browser-laptop? no

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Reproduced by @srirambv

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 13, 2018

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants