Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in canceled requests with GURL access #1664

Closed
kjozwiak opened this issue Oct 17, 2018 · 0 comments · Fixed by brave/brave-core#666
Closed

Crash in canceled requests with GURL access #1664

kjozwiak opened this issue Oct 17, 2018 · 0 comments · Fixed by brave/brave-core#666

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 17, 2018

Description

When I woke up this morning and woke my MBP, quitting brave produced an instant crash.

Steps to Reproduce

  1. install & launch 0.55.16 Chromium: 70.0.3538.54 (release)
  2. once installed, open a few tabs, windows etc..
  3. hibernate the machine (in my case, I closed the MBP lid and went to sleep)
  4. wake the machine, and attempt quitting Brave

Note: I'm not 100% sure if these STR will work but this is what I did last night before reproducing the crash this morning when I attempted to quite Brave.

Actual result:

After waking up my machine, quitting Brave produced the following crash:

Expected result:

Brave shouldn't crash when quitting the application

Reproduces how often:

I'm not 100% sure as I only received the one crash and mentioned it in Slack. @bbondy took a look and found the issue.

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@kjozwiak kjozwiak added the crash label Oct 17, 2018
@kjozwiak kjozwiak added this to the FROZEN: 0.55.x - Release milestone Oct 17, 2018
@kjozwiak kjozwiak changed the title editing in progress Crash in canceled requests with GURL access Oct 17, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 17, 2018
@kjozwiak kjozwiak added the QA/No label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant