Custom notifications are shown when native(system) notifications are enabled #18342

btlechowski · 2021-09-24T16:25:05Z

native(system) notifications must be used when native(system) notifications are enabled and
For Windows 10 build 17134 and newer (should not be shown if Focus Assist is enabled)
For macOS 10.14 and newer if native notifications are enabled
For Android 8 and newer

More info brave/brave-variations#120

Steps to Reproduce

Enable native(system) notifications
Run Brave with --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://variations.bravesoftware.com/seed
Restart Brave
Make sure variations are downloaded in brave://version
Enable rewards and ads
Trigger an ad

Actual result:

Custom notification is shown

Expected result:

native(system) notifications is shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.30.84 Chromium: 94.0.4606.54 (Official Build) (64-bit)
Revision	c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS	Windows 10 Version 20H2 (Build 19042.1237)

cc @brave/legacy_qa @rebron @tmancey @jsecretan

The text was updated successfully, but these errors were encountered:

kjozwiak · 2021-09-24T16:34:06Z

As @btlechowski mentioned, this is also reproducible on macOS 11.5.2 x64 as well. Even though you have system notifications enabled via Notifications under System Notifications, you're always going to get added into the following and you'll get custom ad notifications 100% of the time even though native notifications should be shown/used:

[9007:259:0924/120415.982593:VERBOSE1:features.cc(45)] Study BraveAds.ShowCustomAdNotificationOnMacStudy is active (Enabled)

This is in relation to brave/brave-variations#120. Specifically:

Native ad notifications should be displayed via the following when:

for macOS 10.14 and newer if native notifications are enabled - seeing custom ad notifications
for Windows 10 build 17134 and newer (should not be shown if Focus Assist is enabled) - seeing custom ad notifications

tmancey · 2021-09-24T19:45:31Z

@btlechowski fixed via variations seed

kjozwiak · 2021-09-27T17:45:24Z

Once we get RC builds, we should quickly run through brave/brave-variations#129 to make sure things are working as expected. There's some notes/better STR/Cases outlined via brave/brave-variations#120 which is the same PR but merged into main (staging).

GeetaSarvadnya · 2021-09-28T08:33:01Z

Verification passed on


Brave | 1.30.86 Chromium: 94.0.4606.61 (Official Build) (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Verified the test plan from Rollout custom ad notifications brave-variations#120 (comment) and STR from Custom notifications are shown when native(system) notifications are enabled #18342 (comment)
Encountered issue Custom ad notifications are not shown when system notifications are disabled #18351

Case 1: Show default ad notification

1. Confirmed default ad notifications are delivered when brave is launched via

brave.exe --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6
Native or system notifications are enabled
Focus assist is OFF

Case 1.1: Show default ad notification

Confirmed default ad notifications are delivered when brave is launched via

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-debug --variations-server-url=https://variations.brave.com/seed
Native or system notifications are enabled
Focus assist is OFF
Windows 10 build 17134 and newer (Windows 10 build is 19043.1237 in my machine)

Case 2: Show custom ad notification

3. Confirmed custom ad notifications are delivered when brave is launched via

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-debug --variations-server-url=https://variations.brave.com/seed
Native or system notifications are disabled
Focus assist is OFF
Windows 10 build 17134 and newer (Windows 10 build is 19043.1237 in my machine)

Actual: Custom ad notifications are not shown, in fact all the notifications are blocked, Encountered the issue #18351

Case 3 : Show custom ad notification (enable custom ads via brave://flags)

4. Confirmed custom ad notifications are delivered when brave is launched via

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-debug --variations-server-url=https://variations.brave.com/seed
Native or system notifications are enabled
Enable Brave Ads custom notifications via brave://flags
Focus assist is OFF
Windows 10 build 17134 and newer (Windows 10 build is 19043.1237 in my machine)

Verification PASSED on macOS 11.6 x64 using the following build:

Brave | 1.30.86 Chromium: 94.0.4606.61 (Official Build) (x86_64)
--- | ---
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | macOS Version 11.6 (Build 20G165)

`Test Case #1` (default installation/native notifications)

launched 1.30.86 Chromium: 94.0.4606.61
restarted 1.30.86 Chromium: 94.0.4606.61 and ensured that variations are loaded/being used via brave://version

[5695:259:0928/091426.836456:VERBOSE1:features.cc(45)] Study BraveAds.FrequencyCappingStudy is active (ExcludeAdIfWithinTimeWindow=0h)
[5695:259:0928/091426.836489:VERBOSE1:features.cc(45)] Study BraveAds.UserActivityStudy is active (Triggers=EMPTY/Threshold=0.0/IdleTimeThreshold=5)

enabled rewards using the rewards panel and triggered an ad notification
ensured that a native ad notification was being displayed/used

`Example`	`Example`

`Test Case #2` (native notifications disabled)

launched 1.30.86 Chromium: 94.0.4606.61
disabled native notifications via brave://flags/#enable-system-notifications and restarted 1.30.86 Chromium: 94.0.4606.61
ensured that variations are loaded/being used via brave://version

[7494:259:0928/093320.828418:VERBOSE1:features.cc(45)] Study BraveAds.FrequencyCappingStudy is active (ExcludeAdIfWithinTimeWindow=0h)
[7494:259:0928/093320.828448:VERBOSE1:features.cc(45)] Study BraveAds.UserActivityStudy is active (Triggers=EMPTY/Threshold=0.0/IdleTimeThreshold=5)

enabled rewards using the rewards panel and triggered an ad notification
ensured that a custom ad notification was being displayed/used

`Example`	`Example`

Verification passed on

Brave	1.30.86 Chromium: 94.0.4606.61 (Official Build) (64-bit)
Revision	418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-variations#120

Verified on Linux Custom ads are enabled by default.

Verification passed on

Brave	1.30.86 Chromium: 94.0.4606.61 (Official Build) (64-bit)
Revision	418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-variations#120

Verified on Linux Custom ads are enabled by default.

srirambv · 2021-09-28T12:14:18Z

Verification passed on Oppo Reno 5 with Android 11 running 1.30.86 x64 build

Verified test plan from Rollout custom ad notifications brave-variations#120 & issue description
Verified default ad notification is shown when native notifications are enabled
Verified custom ad notification is shown when flag is enabled and native notifications are disabled
Encountered Custom ad notifications are not shown when system notifications are disabled #18351 on Android as well when using command line flag for variations and disabling native notifications

Native Ads	Custom Ads via Flags

btlechowski added release/blocking QA/Yes QA/Test-Plan-Specified feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 24, 2021

btlechowski added this to the 1.30.x - Release milestone Sep 24, 2021

tmancey self-assigned this Sep 24, 2021

tmancey closed this as completed Sep 24, 2021

LaurenWags added the release-notes/exclude label Sep 27, 2021

btlechowski mentioned this issue Sep 27, 2021

Rollout custom ad notifcations brave/brave-variations#129

Merged

kjozwiak added QA/No and removed QA/Yes labels Sep 27, 2021

kjozwiak mentioned this issue Sep 27, 2021

[MacOS] Do not override notifications to alerts for the browser app. #18345

Closed

kjozwiak added QA/Yes and removed QA/No labels Sep 27, 2021

srirambv added the QA Pass - Android ARM label Sep 28, 2021

btlechowski added QA/Test-All-Platforms QA Pass-Linux labels Sep 28, 2021

kjozwiak added the QA Pass-macOS label Sep 28, 2021

btlechowski added the QA Pass-Win64 label Sep 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom notifications are shown when native(system) notifications are enabled #18342

Custom notifications are shown when native(system) notifications are enabled #18342

btlechowski commented Sep 24, 2021

kjozwiak commented Sep 24, 2021

tmancey commented Sep 24, 2021

kjozwiak commented Sep 27, 2021 •

edited

Loading

GeetaSarvadnya commented Sep 28, 2021 •

edited by btlechowski

Loading

srirambv commented Sep 28, 2021

Custom notifications are shown when native(system) notifications are enabled #18342

Custom notifications are shown when native(system) notifications are enabled #18342

Comments

btlechowski commented Sep 24, 2021

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

kjozwiak commented Sep 24, 2021

tmancey commented Sep 24, 2021

kjozwiak commented Sep 27, 2021 • edited Loading

GeetaSarvadnya commented Sep 28, 2021 • edited by btlechowski Loading

Test Case #1 (default installation/native notifications)

Test Case #2 (native notifications disabled)

srirambv commented Sep 28, 2021

kjozwiak commented Sep 27, 2021 •

edited

Loading

GeetaSarvadnya commented Sep 28, 2021 •

edited by btlechowski

Loading

`Test Case #1` (default installation/native notifications)

`Test Case #2` (native notifications disabled)