Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state machine to vpn service #18422

Closed
Tracked by #15804
simonhong opened this issue Sep 29, 2021 · 0 comments · Fixed by brave/brave-core#10466
Closed
Tracked by #15804

Add state machine to vpn service #18422

simonhong opened this issue Sep 29, 2021 · 0 comments · Fixed by brave/brave-core#10466
Assignees
@simonhong
Labels
feature/vpn OS/Desktop QA/No release-notes/exclude
Milestone
1.33.x - Release

Comments

@simonhong
Copy link
Member

vpn service is based on many async tasks such as fetching hostnames from guardian service.
Due to this, vpn service could not proceed next step before completing current async tasks.
When previous async task is done, vpn service should know what it should do as a next.
With state machine, vpn service could determine next task when previous task is done.
@simonhong simonhong self-assigned this Sep 29, 2021
@simonhong simonhong mentioned this issue Sep 29, 2021
Closed
38 tasks
@simonhong simonhong mentioned this issue Oct 12, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Oct 26, 2021
@simonhong
Improved vpn connect/disconnect logic
ef04ff3 
Whenever connect is asked, vpn service tries to create os vpn entry
with latest hostname and user credentials from guardian service.

fix brave/brave-browser#18648
fix brave/brave-browser#18422
simonhong added a commit to brave/brave-core that referenced this issue Oct 29, 2021
@simonhong
Improved vpn connect/disconnect logic
015ce0e 
Whenever connect is asked, vpn service tries to create os vpn entry
with latest hostname and user credentials from guardian service.

fix brave/brave-browser#18648
fix brave/brave-browser#18422
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Brave VPN desktop service status handling brave/brave-core
1 participant
@simonhong