-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave VPN desktop service status handling #10466
Conversation
1c13aef
to
7c5511b
Compare
f701789
to
e429127
Compare
e429127
to
276ffe9
Compare
c97abce
to
6a814b2
Compare
6a814b2
to
668517c
Compare
668517c
to
ef04ff3
Compare
Whenever connect is asked, vpn service tries to create os vpn entry with latest hostname and user credentials from guardian service. fix brave/brave-browser#18648 fix brave/brave-browser#18422
ef04ff3
to
56db76c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All addressed by 56db76c
@bsclifton PTAL.
fdb0b35
to
849449c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! And thanks for adding the GetEnvironment 😄👍
849449c
to
9c9952c
Compare
Merged with skip because last change was deleting simple unused header including. |
Whenever connect is asked, vpn service tries to create os vpn entry
with latest hostname and user credentials from guardian service.
fix brave/brave-browser#18648
fix brave/brave-browser#18422
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
npm run test brave_unit_tests -- --filter=*VPN*
--brave-vpn-test-monthly-pass=xxxxxx
testable pass