Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave VPN desktop service status handling #10466

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 12, 2021

Whenever connect is asked, vpn service tries to create os vpn entry
with latest hostname and user credentials from guardian service.

fix brave/brave-browser#18648
fix brave/brave-browser#18422

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter=*VPN*

  1. Launch brave and enable vpn feature from brave://flags
  2. Close and launch again with --brave-vpn-test-monthly-pass=xxxxxx testable pass
  3. Click vpn button and launch vpn panel and try connect/disconnect and change region

@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch 17 times, most recently from 1c13aef to 7c5511b Compare October 15, 2021 11:55
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from f701789 to e429127 Compare October 18, 2021 09:08
@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 18, 2021
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from e429127 to 276ffe9 Compare October 18, 2021 09:54
@simonhong simonhong marked this pull request as ready for review October 18, 2021 09:57
@simonhong simonhong changed the title Brave VPN desktop service status handling WIP: Brave VPN desktop service status handling Oct 18, 2021
@simonhong simonhong added CI/skip-macos-x64 Do not run CI builds for macOS x64 and removed CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 18, 2021
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from c97abce to 6a814b2 Compare October 20, 2021 03:17
@simonhong simonhong removed CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 26, 2021
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from 6a814b2 to 668517c Compare October 26, 2021 05:35
@simonhong simonhong changed the title WIP: Brave VPN desktop service status handling Brave VPN desktop service status handling Oct 26, 2021
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from 668517c to ef04ff3 Compare October 26, 2021 10:14
Whenever connect is asked, vpn service tries to create os vpn entry
with latest hostname and user credentials from guardian service.

fix brave/brave-browser#18648
fix brave/brave-browser#18422
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from ef04ff3 to 56db76c Compare October 29, 2021 13:07
Copy link
Member Author

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All addressed by 56db76c

@bsclifton PTAL.

@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch 2 times, most recently from fdb0b35 to 849449c Compare October 30, 2021 01:45
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! And thanks for adding the GetEnvironment 😄👍

@simonhong simonhong added the CI/skip Do not run CI builds (except noplatform) label Nov 1, 2021
@simonhong simonhong force-pushed the brave_vpn_service_state_machine branch from 849449c to 9c9952c Compare November 1, 2021 05:47
@simonhong
Copy link
Member Author

Merged with skip because last change was deleting simple unused header including.

@simonhong simonhong merged commit 6f6d3c8 into master Nov 1, 2021
@simonhong simonhong deleted the brave_vpn_service_state_machine branch November 1, 2021 06:23
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get subscriber credentials from vendor after SKU credential is set Add state machine to vpn service
3 participants