Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reset report uploader #1844

Closed
pilgrim-brave opened this issue Oct 25, 2018 · 3 comments · Fixed by brave/brave-core#745
Closed

Disable reset report uploader #1844

pilgrim-brave opened this issue Oct 25, 2018 · 3 comments · Fixed by brave/brave-core#745

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Oct 25, 2018

Settings → Advanced → "Restore settings to their original defaults" brings up a pseudo-dialog that says "This will reset your startup page, new tab page, search engine, and pinned tabs. It will also disable all extensions and clear temporary data like cookies. Your bookmarks, history and saved passwords will not be cleared. Learn more"

The "learn more" link points to a Brave support page (good), but under the text is a checkbox (selected by default) "Help make Brave better by reporting the current settings". If checked, selecting the "Reset settings" button will send a report to a Google-owned server.

Relevant code: https://cs.chromium.org/chromium/src/chrome/browser/profile_resetter/reset_report_uploader.cc

According to @bbondy, we should

  • keep the "reset settings" functionality, but
  • unconditionally disable uploading of current settings
  • hide the UI (checkbox) that offers the choice of uploading

Verification of upload disabling is covered by automated browser tests.

Test plan for verification of UI changes:

  1. Navigate to brave://settings
  2. Click 'Advanced'
  3. Under 'Reset settings', click 'Restore settings to their original defaults'
  4. Verify that pseudo-dialog appears, titled 'Reset settings' with some explanatory text and two buttons 'Cancel' and 'Reset settings'
  5. Verify that there is NOT a checkbox that says "Help make Brave better by reporting the current settings"
@pilgrim-brave pilgrim-brave self-assigned this Oct 25, 2018
@pilgrim-brave pilgrim-brave added the privacy/connect This requires making a network connection to a third-party service. label Oct 25, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Oct 26, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 28, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Nightly Oct 30, 2018
@srirambv
Copy link
Contributor

@pilgrim-brave can you add QA/Yes/QA/No label and any test steps in the issue/PR accordingly?

@pilgrim-brave
Copy link
Author

Updated with test plan

@srirambv
Copy link
Contributor

srirambv commented Dec 12, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

screenshot from 2018-12-12 16-14-24

Verification is passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

image

Verified passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified steps from test plan
    screen shot 2018-12-12 at 4 38 38 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants