-
Notifications
You must be signed in to change notification settings - Fork 868
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable reset report uploader and hide UI
Fixes brave/brave-browser#1844
- Loading branch information
1 parent
74300e4
commit 11c77f6
Showing
3 changed files
with
50 additions
and
0 deletions.
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
patches/chrome-browser-profile_resetter-reset_report_uploader.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| diff --git a/chrome/browser/profile_resetter/reset_report_uploader.cc b/chrome/browser/profile_resetter/reset_report_uploader.cc | ||
| index 696cd4a6127f..24e6ce8873ed 100644 | ||
| --- a/chrome/browser/profile_resetter/reset_report_uploader.cc | ||
| +++ b/chrome/browser/profile_resetter/reset_report_uploader.cc | ||
| @@ -48,6 +48,7 @@ void ResetReportUploader::DispatchReport( | ||
|
|
||
| void ResetReportUploader::DispatchReportInternal( | ||
| const std::string& request_data) { | ||
| + return; // feature disabled in Brave | ||
| // Create traffic annotation tag. | ||
| net::NetworkTrafficAnnotationTag traffic_annotation = | ||
| net::DefineNetworkTrafficAnnotation("profile_resetter_upload", R"( |
15 changes: 15 additions & 0 deletions
15
patches/chrome-browser-resources-settings-reset_page-reset_profile_dialog.html.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | ||
| index 64a6823036ba..714324e2a13f 100644 | ||
| --- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | ||
| +++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html | ||
| @@ -44,10 +44,6 @@ | ||
| $i18n{resetDialogCommit} | ||
| </paper-button> | ||
| </div> | ||
| - <div slot="footer"> | ||
| - <cr-checkbox id="sendSettings" checked> | ||
| - $i18nRaw{resetPageFeedback}</cr-checkbox> | ||
| - </div> | ||
| </cr-dialog> | ||
| </template> | ||
| <script src="reset_profile_dialog.js"></script> |
23 changes: 23 additions & 0 deletions
23
patches/chrome-browser-resources-settings-reset_page-reset_profile_dialog.js.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js | ||
| index 0291bfffdcd5..12ff081941f1 100644 | ||
| --- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js | ||
| +++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js | ||
| @@ -75,9 +75,6 @@ Polymer({ | ||
| this.addEventListener('cancel', () => { | ||
| this.browserProxy_.onHideResetProfileDialog(); | ||
| }); | ||
| - | ||
| - this.$$('cr-checkbox a') | ||
| - .addEventListener('click', this.onShowReportedSettingsTap_.bind(this)); | ||
| }, | ||
|
|
||
| /** @private */ | ||
| @@ -123,7 +120,7 @@ Polymer({ | ||
| this.clearingInProgress_ = true; | ||
| this.browserProxy_ | ||
| .performResetProfileSettings( | ||
| - this.$.sendSettings.checked, this.resetRequestOrigin_) | ||
| + false, this.resetRequestOrigin_) | ||
| .then(() => { | ||
| this.clearingInProgress_ = false; | ||
| if (this.$.dialog.open) |