Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR96: The Task Manager uses wrong highlight color #19241

Closed
Tonev opened this issue Nov 5, 2021 · 3 comments · Fixed by brave/brave-core#10908
Closed

CR96: The Task Manager uses wrong highlight color #19241

Tonev opened this issue Nov 5, 2021 · 3 comments · Fixed by brave/brave-core#10908
Assignees
@mkarolin
Labels
bug OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.32.x - Release

Comments

@Tonev
Copy link
Contributor

Tonev commented Nov 5, 2021

Description

Something has changed during the upgrade to Chromium 96 and now the highlight color in browser's Task Manager is wrong.

Steps to Reproduce

  1. Open the browser.
  2. Open browser's Task Manager.
  3. Observe the highlight color after selecting a process.

Actual result:

actual_one
actual_two

Expected result:

expected_one
expected_two

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave 1.33.62 Chromium: 96.0.4664.27 (Official Build) nightly (64-bit)
Revision 0658dae02ef18b530eda4384920ee23f5e156c55-refs/branch-heads/4664@{#459}
OS Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

@mkarolin
mkarolin added a commit to brave/brave-core that referenced this issue Nov 5, 2021
@mkarolin
[Cr96-followup] Fixes Task Manager colors.
503fff4 
Fixes brave/brave-browser#19241

- Added table selection and grouping colors overrides
- Organized colors by UI elements and alphabetized within

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/9ff93f5baeaa7e547bc56ca3e00c017f74aa7358

commit 9ff93f5baeaa7e547bc56ca3e00c017f74aa7358
Author: Peter Kasting <[email protected]>
Date:   Wed Sep 15 20:32:00 2021 +0000

    Port the majority of ui/views/controls/ to color pipeline.

    Bug: 1249558
@mkarolin mkarolin mentioned this issue Nov 5, 2021
Merged
24 tasks
@mkarolin mkarolin self-assigned this Nov 5, 2021
@mkarolin mkarolin mentioned this issue Nov 5, 2021
Merged
24 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 5, 2021
@stephendonner
Copy link

Thanks as always for your keen eye, @Tonev!

@Tonev
Copy link
Contributor Author

Tonev commented Nov 6, 2021

@stephendonner

Happy to help after receiving such friendly replies 👍

@mkarolin mkarolin added this to the 1.33.x - Nightly milestone Nov 8, 2021
@mkarolin mkarolin mentioned this issue Nov 8, 2021
Merged
24 tasks
@GeetaSarvadnya
Copy link

Verification passed on


Brave | 1.32.97 Chromium: 96.0.4664.35 (Official Build) (64-bit)
-- | --
Revision | 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS | Windows 10 Version 21H1 (Build 19043.1288)
  • Verified the STR from the description

Light mode
image

Dark mode
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

[Cr96-followup] Fixes Task Manager colors. brave/brave-core
6 participants
@stephendonner @kjozwiak @rebron @Tonev @GeetaSarvadnya @mkarolin