Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cr96-followup] Fixes Task Manager colors. #10908

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 5, 2021

Fixes brave/brave-browser#19241

  • Added table selection and grouping colors overrides
  • Organized colors by UI elements and alphabetized within

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/9ff93f5baeaa7e547bc56ca3e00c017f74aa7358

commit 9ff93f5baeaa7e547bc56ca3e00c017f74aa7358
Author: Peter Kasting [email protected]
Date: Wed Sep 15 20:32:00 2021 +0000

Port the majority of ui/views/controls/ to color pipeline.

Bug: 1249558

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Fixes brave/brave-browser#19241

- Added table selection and grouping colors overrides
- Organized colors by UI elements and alphabetized within

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/9ff93f5baeaa7e547bc56ca3e00c017f74aa7358

commit 9ff93f5baeaa7e547bc56ca3e00c017f74aa7358
Author: Peter Kasting <[email protected]>
Date:   Wed Sep 15 20:32:00 2021 +0000

    Port the majority of ui/views/controls/ to color pipeline.

    Bug: 1249558
@mkarolin mkarolin requested a review from a team as a code owner November 5, 2021 17:31
@mkarolin mkarolin self-assigned this Nov 5, 2021
@mkarolin
Copy link
Collaborator Author

mkarolin commented Nov 5, 2021

@simonhong, please, let me know if I shouldn't group them like this. Also, not sure if any additional Mac-specific overrides are needed.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++
I think we should handle separately for macOS task manager.
Its task manager(TaskManagerWindowController) is based on cocoa not views and it doesn't use pipeline color yet.

@mkarolin mkarolin merged commit 0f42a66 into master Nov 8, 2021
@mkarolin mkarolin deleted the maxk-fix-task-manager-colors branch November 8, 2021 17:11
@mkarolin mkarolin added this to the 1.33.x - Nightly milestone Nov 8, 2021
mkarolin added a commit that referenced this pull request Nov 8, 2021
[Cr96-followup] Fixes Task Manager colors.
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.33.70 Chromium: 96.0.4664.35 (Official Build) nightly (64-bit)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS Windows 10 Version 20H2 (Build 19042.1288)
light dark
light dark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CR96: The Task Manager uses wrong highlight color
4 participants