Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://settings/importData screen is blank, and exception is thrown #19364

Closed
stephendonner opened this issue Nov 10, 2021 · 5 comments · Fixed by brave/brave-core#10992
Closed

brave://settings/importData screen is blank, and exception is thrown #19364

stephendonner opened this issue Nov 10, 2021 · 5 comments · Fixed by brave/brave-core#10992
Assignees
@mkarolin
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes regression release/blocking release-notes/exclude
Milestone
1.32.x - Release

Comments

@stephendonner
Copy link

stephendonner commented Nov 10, 2021 •
edited
Loading

Description

brave://settings/importData screen is blank, and exception is thrown

Steps to Reproduce

  1. new profile/install
  2. load brave://settings/importData or click on the 3-dots menu and choose Bookmarks -> Import Bookmarks and Settings
  3. look at the resulting screen

Actual result:

The screen is empty, and an exception is thrown:

Screen Shot 2021-11-10 at 2 47 46 PM

Expected result:

Should pop-up the Import Bookmarks and Settings dialog:

Screen Shot 2021-11-10 at 2 44 49 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.32.97 Chromium: 96.0.4664.35 (Official Build) (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)

/cc @brave/legacy_qa and @mkarolin
@stephendonner
Copy link
Author

Was fine on 1.32.95

Screen Shot 2021-11-10 at 3 12 05 PM

Broken in:

Brave 1.33.74 Chromium: 96.0.4664.35 (Official Build) beta (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)
Brave 1.34.3 Chromium: 96.0.4664.35 (Official Build) nightly (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)

@btlechowski
Copy link

Reproduced on

Brave 1.32.97 Chromium: 96.0.4664.35 (Official Build) (64-bit)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS Ubuntu 18.04 LTS

Also reproducible when importing from NTP
image

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 10, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Nov 10, 2021
@mkarolin
Fixes direct navigation to brave://settings/importData
ce1ed9a 
Fixes brave/brave-browser#19364
@mkarolin mkarolin self-assigned this Nov 10, 2021
@mkarolin mkarolin mentioned this issue Nov 10, 2021
Merged
24 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Nov 11, 2021 •
edited
Loading

Reproduced on my Win 11 x64 machine as well running 1.33.72 Chromium: 96.0.4664.35. Checked the following:

  • directly loading brave://settings/importData via the URL bar - Reproduced
  • loading through the Hamburger -> Bookmarks -> Import bookmarks and settings... - Reproduced
  • loading brave://settings directly in the URL and then selecting Import bookmarks and settings... - Couldn't reproduced

@kjozwiak kjozwiak added this to the 1.32.x - Release milestone Nov 11, 2021
This was referenced Nov 11, 2021
Merged
Merged
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 11, 2021
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 15, 2021 •
edited by btlechowski
Loading

Verification passed on

Brave | 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 10 Version 21H1 (Build 19043.1288)
  • Verified the STR from the description
Case 1: NTP ->Import bookmarks
  • Confirmed click on NTP ->Import bookmarks opens up brave://settings/importData page with Import bookmarks and settings modal popup
  • Confirmed bookmarks can be imported
Example Example Example
image image image
Case 2: Hamburger menu->BM->Import bookmarks and settings
  • Confirmed click on Hamburger menu->BM->Import bookmarks and settings opens up brave://settings/importData page with Import bookmarks and settings modal popup
  • Confirmed bookmarks can be imported
Example Example Example
image image image
Case 3: brave://settings->Import bookmarks and settings
  • Confirmed click on brave://settings->Import bookmarks and settings opens up brave://settings/importData page with Import bookmarks and settings modal popup
  • Confirmed bookmarks can be imported
Example Example Example
image image image
Case 4: Hamburger menu->BM manager->Import bookmarks
  • Confirmed click on Hamburger menu->BM manager->Import bookmarks opens up local directory popup modal to import the bookmarks from the local machine/directory
  • Confirmed bookmarks can be imported
Example Example
image image

Verification passed on

Brave 1.32.103 Chromium: 96.0.4664.45 (Oficjalna wersja) (64-bitowa)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Ubuntu 18.04 LTS
Case 1: NTP ->Import bookmarks
  • Confirmed click on NTP ->Import bookmarks opens up brave://settings/importData page with Import bookmarks and settings modal popup
  • Confirmed bookmarks can be imported

image

Case 2: Hamburger menu->BM->Import bookmarks and settings
  • Confirmed click on Hamburger menu->BM->Import bookmarks and settings opens up brave://settings/importData page with Import bookmarks and settings modal popup
  • Confirmed bookmarks can be imported

image

Case 3: brave://settings->Import bookmarks and settings

image

Case 4: Hamburger menu->BM manager->Import bookmarks
  • Confirmed click on Hamburger menu->BM manager->Import bookmarks opens up local directory popup modal to import the bookmarks from the local machine/directory
  • Confirmed bookmarks can be imported

image

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)
Case 1: NTP -> Import bookmarks * Confirmed click on NTP -> `Import bookmarks...` opens up `brave://settings/importData` page with `Import bookmarks and settings` modal popup * Confirmed bookmarks can be imported
example example example
Screen Shot 2021-11-15 at 9 20 03 AM Screen Shot 2021-11-15 at 9 20 07 AM Screen Shot 2021-11-15 at 9 20 11 AM
Case 2: Hamburger menu -> Bookmarks -> `Import Bookmarks and Settings... * Confirmed click on Hamburger menu -> BM -> `Import bookmarks and settings` opens up `brave://settings/importData` page with `Import bookmarks and settings` modal popup * Confirmed bookmarks can be imported
example example example
Screen Shot 2021-11-15 at 9 23 43 AM Screen Shot 2021-11-15 at 9 23 47 AM Screen Shot 2021-11-15 at 9 23 49 AM
Case 3: brave://settings -> Import bookmarks and settings * Confirmed click on `brave://settings` -> `Import bookmarks and settings` opens up `brave://settings/importData` page with `Import bookmarks and settings` modal popup * Confirmed bookmarks can be imported
example example example
Screen Shot 2021-11-15 at 9 25 34 AM Screen Shot 2021-11-15 at 9 25 36 AM Screen Shot 2021-11-15 at 9 25 39 AM
Case 4: Hamburger menu -> Bookmarks Manager -> Import bookmarks * Confirmed click on Hamburger menu -> BM manager -> `Import bookmarks` opens up local directory popup modal to import the bookmarks from the local machine/directory * Confirmed bookmarks can be imported
example example example
Screen Shot 2021-11-15 at 9 28 02 AM Screen Shot 2021-11-15 at 9 28 19 AM Screen Shot 2021-11-15 at 9 28 24 AM

@stephendonner stephendonner mentioned this issue Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes direct navigation to brave://settings/importData brave/brave-core
6 participants
@stephendonner @kjozwiak @rebron @btlechowski @GeetaSarvadnya @mkarolin