Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes direct navigation to brave://settings/importData (uplift to 1.32.x) #10997

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fixes direct navigation to brave://settings/importData (uplift to 1.32.x) #10997

merged 1 commit into from
Nov 12, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 11, 2021 •
edited by kjozwiak
Loading

Fixes brave/brave-browser#19364
Uplift of #10992

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team November 11, 2021 03:44
@brave-builds brave-builds self-assigned this Nov 11, 2021
@brave-builds brave-builds added this to the 1.32.x - Release milestone Nov 11, 2021
@kjozwiak
Copy link
Member

@mkarolin mind rebasing the PR? You'll need to make sure your branch has #10969 which was uplifted into 1.33.x & 1.32.x via #10990 & #10989.

@mkarolin mkarolin force-pushed the pr10992_maxk-fix-importData_1.32.x branch from e8d6c31 to fd48ed4 Compare November 11, 2021 05:23
@mkarolin mkarolin force-pushed the pr10992_maxk-fix-importData_1.32.x branch from fd48ed4 to bc0f6d3 Compare November 11, 2021 13:40
kjozwiak
kjozwiak approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.32.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10992 (comment).

@kjozwiak kjozwiak merged commit 17cda97 into 1.32.x Nov 12, 2021
@kjozwiak kjozwiak deleted the pr10992_maxk-fix-importData_1.32.x branch November 12, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases