Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We aren’t displaying asset balances until we get prices for them, we should #19407

Closed
bbondy opened this issue Nov 12, 2021 · 1 comment · Fixed by brave/brave-core#11244
Closed

We aren’t displaying asset balances until we get prices for them, we should #19407

bbondy opened this issue Nov 12, 2021 · 1 comment · Fixed by brave/brave-core#11244
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.33.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 12, 2021

When the asset ratio service was timing out and not returning values, we were not displaying token balances even though Infura was up and responding.

The front end code should still display token balances even if the USD balance can't be shown
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 12, 2021
@spylogsster spylogsster mentioned this issue Nov 12, 2021
Merged
7 tasks
@Douglashdaniel Douglashdaniel self-assigned this Nov 16, 2021
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 23, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 23, 2021
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 24, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 29, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2021

Brave 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010) 		☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from brave/brave-core#11244
  • Verified balance is shown when price value fetch is delayed
  • Verified balance and price calls are independent of each other
Balance.Price.-.Linux.mp4
Balance.Price.-.Windows.mov
Balance.Price.-.macOS.mov

@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Separated Balances and Prices Calls brave/brave-core
4 participants
@bbondy @kjozwiak @srirambv @Douglashdaniel