Separated Balances and Prices Calls

[Douglashdaniel]

Description

Separated Balances and Prices Calls

Before we would call for Prices and Balances in the same method and the Balances was dependent on Prices response.
They are now separated into 2 different methods refreshBalances and refreshPrices.
This will now allow Balances to be displayed to the user even if the Prices haven't been returned yet.

(note: In the video I intentionally delayed prices from being fetched for 10 seconds to give an example.)

Resolves brave/brave-browser#19407

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Screen.Recording.2021-11-23.at.11.44.14.AM.mov

[srirambv]

Verification passed on

Brave	1.34.46 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64 translated)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	macOS Version 12.0.1 (Build 21A559)

• Verified balance is shown when price value fetch is delayed
• Verified balance and price calls are independent of each other

11244.mov