Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift to 1.32.x) Signing transactions and messages with Trezor accounts (#10902 #10903) #11035

Merged
merged 2 commits into from
Nov 12, 2021
Merged

(uplift to 1.32.x) Signing transactions and messages with Trezor accounts (#10902 #10903) #11035

merged 2 commits into from
Nov 12, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Nov 12, 2021 •
edited
Loading

Uplift of #10902 #10903
Resolves brave/brave-browser#19029
Resolves brave/brave-browser#19219

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team November 12, 2021 06:52
@spylogsster spylogsster requested review from a team as code owners November 12, 2021 06:52
@spylogsster spylogsster changed the title (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902) WIP: (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902) Nov 12, 2021
@spylogsster spylogsster force-pushed the pr10902_sign_trezor_transactions branch 2 times, most recently from 2f9a2f3 to bbaf8a0 Compare November 12, 2021 15:11
@spylogsster spylogsster force-pushed the pr10902_sign_trezor_transactions branch from bbaf8a0 to 1dacb39 Compare November 12, 2021 15:18
@spylogsster spylogsster changed the title WIP: (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902) (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902) Nov 12, 2021
@spylogsster spylogsster changed the title (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902) (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902 #10903) Nov 12, 2021
@spylogsster spylogsster changed the title (uplift to 1.32.x) Signing Transaction with Trezor accounts (#10902 #10903) (uplift to 1.32.x) Signing transactions and messages with Trezor accounts (#10902 #10903) Nov 12, 2021
@spylogsster
Copy link
Contributor Author

I did not test transactions signing in this branch because of brave/brave-browser#19407

@spylogsster
Sign messages by Trezor (#10903)
bb78c70 
(cherry picked from commit a375958)
@spylogsster spylogsster force-pushed the pr10902_sign_trezor_transactions branch from 6072667 to bb78c70 Compare November 12, 2021 18:09
@kjozwiak
Copy link
Member

Restarting Android as test-unit failed as per https://ci.brave.com/job/pr-brave-browser-pr10902_sign_trezor_transactions-android/6/execution/node/187/log/.

13:50:01  FAILED: obj/brave/test/brave_unit_tests__library/brave_httpse_network_delegate_helper_unittest.o

@kjozwiak kjozwiak added this to the 1.32.x - Release milestone Nov 12, 2021
kjozwiak
kjozwiak approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.32.x approved 👍

@kjozwiak kjozwiak merged commit 8c20070 into 1.32.x Nov 12, 2021
@kjozwiak kjozwiak deleted the pr10902_sign_trezor_transactions branch November 12, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spylogsster @kjozwiak