Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN should have a right click to hide #21163

Closed
Tracked by #15804
bsclifton opened this issue Feb 17, 2022 · 6 comments · Fixed by brave/brave-core#12328
Closed
Tracked by #15804

VPN should have a right click to hide #21163

bsclifton opened this issue Feb 17, 2022 · 6 comments · Fixed by brave/brave-core#12328

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 17, 2022

Test plan

On macOS and Windows only (VPN not available on Linux)

  1. Set brave://flags/#brave-vpn to ENABLED
  2. Set brave://flags/#skus-sdk to ENABLED
  3. Restart the browser
  4. Verify the VPN button shows next to Hamburger menu
  5. Right click the VPN button
  6. You should see the menu:
    image
  7. Pick the "Hide VPN button in toolbar" option
  8. VPN button should disappear

Description

If VPN is enabled, some users may not want to see it.

It would be great if they can right click (or ctrl+click) the VPN icon:
image

And then we can have a context menu show Hide VPN button. This would do the same thing as when you go into settings and using the toggle under appearance:
image

@simonhong simonhong self-assigned this Feb 17, 2022
simonhong added a commit to brave/brave-core that referenced this issue Feb 18, 2022
fix brave/brave-browser#21163

Context menu will be shown with right click or long press.
For not purchased user, only hiding button menu is visible.
For purchased user, feedback, about vpn and manage vpn menu are
also added.
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 18, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.37.60 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1566)

Confirmed:

  • can disable VPN button via context-menu option Hide VPN button in toolbar
  • can enable/disable VPN button via Show VPN button toggle in brave://settings/appearance
  • top-level Brave VPN menu item is available regardless of the toggle state, above
  • clicking both the menu item above and the VPN button on the toolbar launch the onboarding doorhanger dialog
example example example example example
21163-1 21163-2 21163-3 21163-4 21163-5
example example example
21163-6 21163-7 21163-8

@bsclifton
Copy link
Member Author

Quick update - we won't be able to test this on Beta until brave/brave-core#12175 is merged (see #21598)

@stephendonner
Copy link

Quick update - we won't be able to test this on Beta until brave/brave-core#12175 is merged (see #21598)

Setting QA/Blocked so we know to hold off until the above is resolved.

@LaurenWags
Copy link
Member

Removing QA/Test-All-Platforms as this is not available on Linux. The OS/Windows and OS/macOS labels will suffice to ensure this is checked on the appropriate platforms.

@stephendonner
Copy link

  1. Clearing QA Pass-Win64 as this will need to be re-verified using 1.38.x or later.
  2. Settings milestone to 1.38.x as per today's desktop meeting

@LaurenWags
Copy link
Member

Changing to QA/No per discussion in today's desktop planning meeting, testing will be covered with #15804.

@LaurenWags LaurenWags removed the QA/Yes label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment