Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for VPN on Beta #21598

Closed
Tracked by #15804
bsclifton opened this issue Mar 11, 2022 · 2 comments · Fixed by brave/brave-core#12175
Closed
Tracked by #15804

Allow for VPN on Beta #21598

bsclifton opened this issue Mar 11, 2022 · 2 comments · Fixed by brave/brave-core#12175

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 11, 2022

Test plan

  1. Wait until 1.39 is on Beta
  2. Try to run steps from Implement Brave VPN on Desktop #15804

Description

Changes needed so that VPN can move from Nightly to Beta with 1.39 😄

  1. VPN functionality is tied to the Nightly channel at the moment (via build flag). We should expose this feature on brave://flags/#brave-vpn for Beta also.

  2. VPN for Desktop is also requiring that SKU SDK (brave://flags/#skus-sdk) is enabled. We should enable the SKU SDK feature by default

@bsclifton bsclifton assigned bsclifton and simonhong and unassigned bsclifton Mar 11, 2022
petemill pushed a commit to brave/brave-core that referenced this issue Mar 16, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
bsclifton pushed a commit to brave/brave-core that referenced this issue Mar 23, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
simonhong added a commit to brave/brave-core that referenced this issue Mar 28, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
bsclifton pushed a commit to brave/brave-core that referenced this issue Apr 1, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
bsclifton pushed a commit to brave/brave-core that referenced this issue Apr 4, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
bsclifton pushed a commit to brave/brave-core that referenced this issue Apr 6, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
bsclifton pushed a commit to brave/brave-core that referenced this issue Apr 9, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
simonhong added a commit to brave/brave-core that referenced this issue Apr 11, 2022
Made skus sdk enabled by default and vpn feature available on beta.

Fixes brave/brave-browser#21598
@bsclifton bsclifton added this to the 1.39.x - Nightly milestone Apr 13, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.39.84 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

Followed the testplan at #21598 (comment).

Confirmed, from the testplan:

  1. VPN functionality is tied to the Nightly channel at the moment (via build flag). We should expose this feature on brave://flags/#brave-vpn for Beta also.

All three flags are available:

  1. brave://flags/#brave-vpn
  2. brave://flags/#skus-environment
  3. brave://flags/#skus-sdk
SKUs VPN
Screen Shot 2022-04-28 at 6 39 09 PM Screen Shot 2022-04-28 at 6 39 14 PM
  1. VPN for Desktop is also requiring that SKU SDK (brave://flags/#skus-sdk) is enabled. We should enable the SKU SDK feature by default

Confirmed via entering window.chrome.brave into the Developer Tools Console yielded window.chrome.braveSkus, without enabling brave://flags/#skus-sdk (left as Default as seen in screenshot).

Steps:

  1. install 1.39.84
  2. launch Brave using --vmodule="*/skus/*"=1 --enable-logging=stderr
  3. set Enable Experimental Brave VPN to Enabled
  4. set Experimental SKU Environment to Development
  5. click Relaunch
  6. load account.brave.software
  7. enter basic auth creds for site
  8. enter an email address and click Get login link
  9. check your email inbox
  10. click Log in to Brave or the link in the email
  11. click on Browse plans
  12. scroll down and click on Buy now for Brave VPN Subscription
  13. enter payment details on https://checkout.stripe.com/pay/cs_test…
  14. click Subscribe
  15. you should get a Complete your purchase... screen
  16. click on Complete payment

Confirmed I could successfully (and automatically) connect to VPN via the icon and its toggle, in the URL bar.

example example example example example
Screen Shot 2022-04-28 at 6 10 21 PM Screen Shot 2022-04-28 at 6 16 53 PM Screen Shot 2022-04-28 at 5 54 44 PM . Screen Shot 2022-04-28 at 6 20 13 PM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 13, 2022

Verification PASSED on

Brave | 1.39.101 Chromium: 101.0.4951.64 (Official Build) beta (64-bit)
-- | --
Revision | d1daa9897e1bc1d507d6be8f2346e377e5505905-refs/branch-heads/4951@{#1208}
OS | Windows 10 Version 21H2 (Build 19044.1706)

Followed the testplan at #21598 (comment).

Steps:

  1. install 1.39.84
  2. launch Brave using --vmodule="*/skus/*"=1 --enable-logging=stderr
  3. set Enable Experimental Brave VPN to Enabled
  4. set Experimental SKU Environment to Development
  5. click Relaunch
  6. load account.brave.software
  7. enter basic auth creds for site
  8. enter an email address and click Get login link
  9. check your email inbox
  10. click Log in to Brave or the link in the email
  11. click on Browse plans
  12. scroll down and click on Buy now for Brave VPN Subscription
  13. enter payment details on https://checkout.stripe.com/pay/cs_test…
  14. click Subscribe
  15. you should get a Complete your purchase... screen
  16. click on Complete payment

Confirmed I could successfully (and automatically) connect to VPN via the icon and its toggle, in the URL bar.

example example example example example
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment