Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in speedreader_tab_helper.cc on fr-CA locale. #24513

Closed
boocmp opened this issue Aug 8, 2022 · 4 comments · Fixed by brave/brave-core#14524
Closed

Crash in speedreader_tab_helper.cc on fr-CA locale. #24513

boocmp opened this issue Aug 8, 2022 · 4 comments · Fixed by brave/brave-core#14524

Comments

@boocmp
Copy link

boocmp commented Aug 8, 2022

Description

Steps to Reproduce

  1. Change locale to fr-CA
  2. Open speedreadable page

Actual result:

Check is fired. Browser crashed.

Expected result:

No crash.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Aug 8, 2022

Reproduced with

Brave | 1.42.88 Chromium: 104.0.5112.81 (Build officiel) (x86_64)
-- | --
Révision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
Système d'exploitation | macOS Version 12.5 (assemblage 21G72)

Used STR from: https://bravesoftware.slack.com/archives/C7VLGSR55/p1659940674200729?thread_ts=1659939937.498489&cid=C7VLGSR55

pre-req: set my OS language to French and my region to Canada

  1. Clean profile 1.42.88
  2. Navigated to https://twitter.com/AlecMuffett/status/1501282223009542151?ref_src=twsrc%5Etfw
  3. Scrolled down to https://twitter.com/AlecMuffett/status/1501529013835210754
  4. Middle clicked on https://t.co/Kk5pWwUkiv (alecmuffett.com link) to open in new tab
  5. Clicked on speed reader icon in URL bar --> crash

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.42.91 Chromium: 104.0.5112.81 (Official Build) (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.856)

Reproduced with 1.42.88 Chromium: 104.0.5112.81
Verified with STR #24513 (comment)
Confirmed Brave crashed when clicked on speed reader icon

Ex1 Ex2
image 1 image 1
  1. installed 1.42.91
  2. launch Brave
  3. restarted the browser
  4. verified the text SpeedreaderReleaseStudy:Enabled via brave://version
  5. navigated to https://twitter.com/AlecMuffett/status/1501282223009542151?ref_src=twsrc%5Etfw
  6. scrolled down to https://twitter.com/AlecMuffett/status/1501529013835210754
  7. middle clicked on https://t.co/Kk5pWwUkiv (alecmuffett.com link) to open in new tab
  8. clicked on speed reader icon
  9. enabled speed reader

Confirmed Brave didn't crash

step 4 Step 7 Step 9
image 1 image 1 image 1

@stephendonner
Copy link

Verified PASSED using

Brave 1.42.91 Chromium: 104.0.5112.81 (Build officiel) (x86_64)
Révision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
Système d'exploitation macOS Version 13.0 (assemblage 22A5321d)

Reproduced the crash using 1.42.88; followed the steps to reproduce at #24513 (comment).

Confirmed I no longer crash:

example example
Capture d’écran, le 2022-08-10 à 11 05 46 Capture d’écran, le 2022-08-10 à 11 15 04

@btlechowski
Copy link

Verification passed on

Brave 1.42.95 Chromium: 104.0.5112.81 (Official Build) (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Ubuntu 18.04 LTS

Reproduced the crash in 1.42.88
image

Verified speed reader enabled
image

Verified no crash
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment