Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECK removed in favor of character escaping. #14524

Merged
merged 1 commit into from
Aug 9, 2022
Merged

CHECK removed in favor of character escaping. #14524

merged 1 commit into from
Aug 9, 2022

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Aug 8, 2022

Resolves brave/brave-browser#24513

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@boocmp boocmp requested a review from diracdeltas August 8, 2022 12:12
@boocmp boocmp requested a review from iefremov as a code owner August 8, 2022 12:12
@boocmp boocmp self-assigned this Aug 8, 2022
@boocmp boocmp merged commit 7a6ce03 into master Aug 9, 2022
@boocmp boocmp deleted the issues/24513 branch August 9, 2022 06:15
@boocmp boocmp restored the issues/24513 branch August 9, 2022 06:15
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 9, 2022
@boocmp boocmp deleted the issues/24513 branch August 9, 2022 07:40
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.44.32 Chromium: 104.0.5112.81 (Official Build) nightly (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.832)

Reproduced the issue using the STR/Cases from brave/brave-browser#24513 (comment) using 1.42.88 Chromium: 104.0.5112.81 and ensured the issue wasn't reproduced via 1.44.32 Chromium: 104.0.5112.81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in speedreader_tab_helper.cc on fr-CA locale.
4 participants