Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable notifications message on Android 13 should only be shown once #26930

Closed
srirambv opened this issue Nov 22, 2022 · 3 comments · Fixed by brave/brave-core#16079
Closed

Comments

@srirambv
Copy link
Contributor

Description

Enable notifications message on Android 13 should only be shown once

Steps to reproduce

Same as brave/brave-core#15407

Actual result

Notification is shown every time the app is restarted

Expected result

Should only show once

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 13

Brave version

1.47.91

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Discussed here
cc: @timchilds @sujitacharya2005

@kjozwiak
Copy link
Member

The above requires 1.46.130 or higher for 1.46.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2022

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.46.133 Chromium: 108.0.5359.71 (Official Build) (32-bit)
--- | ---
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Android 13; Build/TP1A.220624.014

Using the STR/Cases outlined via #26930 (comment), ensured the following:

  • ensured that the You're not receiving Privacy Reports modal only appears once when dismissing via
    • using X, clicking on Not now or clicking on Turn on Brave notifications (but not enabling)
    • ensured that the modal never re-appears again (visiting settings/restarted the browser etc..)
Screen_Recording_20221201_125219_Brave.mp4
  • ensured that the You're not earning Rewards modal only appears once when dismissing via
    • using X, clicking on Not now or clicking on Turn on Brave notifications (but not enabling)
    • ensured that the modal never re-appears again (visiting settings/restarted the browser etc..)
Screen_Recording_20221201_130025_Brave.mp4
  • ensured that the You're not earning Rewards or receiving Privacy Reports modal only appears once when dismissing via
    • using X, clicking on Not now or clicking on Turn on Brave notifications (but not enabling)
    • ensured that the modal never re-appears again (visiting settings/restarted the browser etc..)
Screen_Recording_20221201_130304_Brave.mp4

@kjozwiak
Copy link
Member

kjozwiak commented Dec 1, 2022

Verification PASSED on Samsung Galaxy S10+ running Android 13 using the following build(s):

Brave | 1.46.133 Chromium: 108.0.5359.71 (Official Build) (32-bit)
--- | ---
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Android 13; Build/T1B3.221003.008

Using the STR/Cases outlined via #26930 (comment), ensured the following:

  • ensured that the You're not receiving Privacy Reports modal only appears once when dismissing via
    • using X, clicking on Not now or clicking on Turn on Brave notifications (but not enabling)
    • ensured that the modal never re-appears again (visiting settings/restarted the browser etc..)
screen-20221201-141802.mp4
  • ensured that the You're not earning Rewards modal only appears once when dismissing via
    • using X, clicking on Not now or clicking on Turn on Brave notifications (but not enabling)
    • ensured that the modal never re-appears again (visiting settings/restarted the browser etc..)

https://youtube.com/shorts/hDsoFPFA-Uc

  • ensured that the You're not earning Rewards or receiving Privacy Reports modal only appears once when dismissing via
    • using X, clicking on Not now or clicking on Turn on Brave notifications (but not enabling)
    • ensured that the modal never re-appears again (visiting settings/restarted the browser etc..)

https://youtu.be/oBa-qJXLJQ0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment