Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 13 show once notification permission dialog #16079

Merged

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Nov 24, 2022

Resolves brave/brave-browser#26930

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 24, 2022
@sujitacharya2005 sujitacharya2005 added this to the 1.48.x - Nightly milestone Nov 24, 2022
@sujitacharya2005 sujitacharya2005 force-pushed the android_13_notification_permission_dialog_once branch from 74d386a to 37454d4 Compare November 24, 2022 09:59
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to refactor prefs here and update it with SharedPreferenceManager. Can you create an issue for it ?

* Sets the user preference for whether the Notification Permission Enabling dialog is shown.
*/
public void setNotificationPermissionEnablingDialogShown(boolean isShown) {
SharedPreferences.Editor sharedPreferencesEditor = mSharedPreferences.edit();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start using SharedPreference Manager for all pref updates.

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will address refactoring part in upcoming issue.

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 37454d4
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

@kjozwiak
Copy link
Member

Verification PASSED on Samsung Galaxy S10+ running Android 13 using the following build(s):

Brave | 1.48.9 Chromium: 108.0.5359.48 (Official Build) canary (32-bit)
--- | ---
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | Android 13; Build/T1B3.221003.008

Created brave/brave-browser#27002 after discussing with @deeppandya & @sujitacharya2005.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable notifications message on Android 13 should only be shown once
3 participants