Can't connect to server dialog appears after removing BraveVPN config and trying to reconnect

[stephendonner]

Description

Can't connect to server dialog appears after removing BraveVPN config and trying to reconnect

Steps to Reproduce

1. install 1.46.134
2. launch Brave
3. open brave://flags
4. set brave://flags/#brave-vpn to Enabled
5. click on Relaunch
6. load account.bravesoftware.com
7. click on Buy now under Brave VPN & Firewall
8. complete Stripe checkout
9. click on the VPN button
10. connect to VPN
11. accept the OS network-config dialog
12. try to connect to BraveVPN

Actual result:

Can't connect to server dialog is shown. I also see this in the console:

[11899:259:1206/151621.250347:ERROR:brave_vpn_os_connection_api_mac.mm(250)] Connect - startVPNTunnel error: The operation couldn’t be completed. (NEVPNErrorDomain error 1.)

Expected result:

Should be able to connect to BraveVPN

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.46.134 Chromium: 108.0.5359.94 (Official Build) (x86_64)
Revision	713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS	macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @mattmcalister @bsclifton @simonhong @brave/qa-team @rebron @simonhong @spylogsster

[stephendonner]

I don't think this is a launch blocker, but it'd be nice to get a fix ASAP, if we can.

[simonhong]

Reopened as this is still reproducible on macOS.

[kjozwiak]

The above requires 1.47.130 or higher for 1.47.x verification 👍

[stephendonner]

Verified PASSED using

Brave	1.47.132 Chromium: 108.0.5359.128 (Official Build) beta (x86_64)
Revision	1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS	macOS Version 11.7.2 (Build 20G1020)

Followed my original steps to reproduce.

Confirmed I never saw the Can't connect to server dialog after removing the BraveVPN config