Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to create os vpn entry whenever connect starts #16284

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 8, 2022

fix brave/brave-browser#27196

When user deletes os vpn entry while browser running, browser can't know that deletion.
So, connect again w/o creating os entry causes connect error.
To fix this, try to create os vpn entry whenever connect.
As creating os vpn entry is cheap and fast, it would not hurt UX.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch Brave and prepare for using vpn
  2. Connect and disconnect
  3. Go to system setting and delete os vpn entry
  4. Connect again and check connect failed doesn't happen

fix brave/brave-browser#27196

When user deletes os vpn entry while browser running, browser can't know
that deletion. So, connect again w/o creating os entry causes connect
error. To fix this, try to create os vpn entry whenever connect.
As creating os vpn entry is cheap and fast, it would not hurt UX.
@simonhong simonhong self-assigned this Dec 8, 2022
Copy link
Contributor

@spylogsster spylogsster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

⚠️ PR head is an unsigned commit
commit: 196824f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

@simonhong simonhong merged commit fb7dfac into master Dec 8, 2022
@simonhong simonhong deleted the create_os_vpn_entry_when_connect branch December 8, 2022 13:27
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 8, 2022
brave-builds pushed a commit that referenced this pull request Dec 8, 2022
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.48.55 Chromium: 108.0.5359.128 (Official Build) nightly (x86_64)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS macOS Version 11.7.2 (Build 20G1020)

Steps

Followed my original steps to reproduce from brave/brave-browser#27196, plus additional testing.

Confirmed I could remove, and dynamically add, the BraveVPN macOS config, without the Couldn't connect to server errors popping up

Screencast

vpn-retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect to server dialog appears after removing BraveVPN config and trying to reconnect
3 participants