Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to create os vpn entry whenever connect starts (uplift to 1.47.x) #16303

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Try to create os vpn entry whenever connect starts (uplift to 1.47.x) #16303

merged 2 commits into from
Dec 15, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 8, 2022 •
edited by kjozwiak
Loading

Uplift of #16284 #16285
fix brave/brave-browser#27196
fix brave/brave-browser#27267

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner December 8, 2022 23:33
@brave-builds brave-builds self-assigned this Dec 8, 2022
@brave-builds brave-builds added this to the 1.47.x - Beta milestone Dec 8, 2022
@simonhong
Merge pull request #16285 from brave/brave_vpn_change_region_status
7dfd595 
Ignore disconnected status while changing region
kjozwiak
kjozwiak approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16284 (comment) & #16285 (comment).

@kjozwiak kjozwiak merged commit 2f7f5aa into 1.47.x Dec 15, 2022
@kjozwiak kjozwiak deleted the pr16284_create_os_vpn_entry_when_connect_1.47.x branch December 15, 2022 06:52
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 7dfd595
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @brave-browser-releases @simonhong